<p>Done a few changes here.</p>
<p>I refactored the with_destination locale so its just a string that one can append onto the end of an instruction. Hopefully it will still work with different grammar structures in different languages!</p>
<p>I also fixed some ambiguous roundabout instructions..<br>
i.e. <a href="https://www.openstreetmap.org/directions?engine=osrm_car&route=53.7338%2C-1.5258%3B53.6832%2C-1.4999#map=13/53.7086/-1.5171" rel="nofollow">https://www.openstreetmap.org/directions?engine=osrm_car&route=53.7338%2C-1.5258%3B53.6832%2C-1.4999#map=13/53.7086/-1.5171</a></p>
<p>Instructions 7-16 are a bit weird - so I've fixed it to specify <code>"Exit straight/slight right/right from roundabout"</code> when exiting roundabouts</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1805'>https://github.com/openstreetmap/openstreetmap-website/pull/1805</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Refactored destinations locale into separate instruction</li>
<li>Refactored locale templates and fixed roundabout exiting templates</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1805/files#diff-0">app/assets/javascripts/index/directions/osrm.js</a>
(29)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1805/files#diff-1">config/locales/en.yml</a>
(80)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1805.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1805.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1805.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1805.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1805">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLZhAv60johHjItKIJ1qZ9fe0sVQ_ks5tkOi3gaJpZM4TC2tG">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLUlLTrffWGCoH4ohC0I08oZgdoufks5tkOi3gaJpZM4TC2tG.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1805"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix destinations and roundabouts locale (#1805)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1805"}}}</script>