<p><b>@tomhughes</b> requested changes on this pull request.</p>

<p>In addition to the inline comments this needs some tests - at the very least the new route needs adding to the route tests in the user controller tests and there should be a test of the controller method as well.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1868#discussion_r188805507">app/assets/javascripts/index/contextmenu.js</a>:</p>
<pre style='color:#555'>> @@ -72,6 +72,22 @@ OSM.initializeContextMenu = function (map) {
     }
   });
 
+  map.contextmenu.addItem({
+    text: I18n.t("javascripts.context.set_home_location"),
+    callback: function setHomeLocation(e) {
+      var precision = OSM.zoomPrecision(map.getZoom()),
+          latlng = e.latlng.wrap(),
+          lat = latlng.lat.toFixed(precision),
+          lng = latlng.lng.toFixed(precision);
+      
+      $.ajax({url: "/set_home_loc?lat=" + lat + "&lon=" + lng, success: function(){
</pre>
<p>I wonder if this should be a <code>POST</code> request? It is technically idempotent I guess, but having <code>GET</code> requests modify state doesn't really seem right.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1868#discussion_r188805597">config/routes.rb</a>:</p>
<pre style='color:#555'>> @@ -256,6 +256,9 @@
   # directions
   get "/directions" => "directions#search"
 
+  # set home location
+  match "/set_home_loc" => "user#set_home_location", :via => [:get, :post]
</pre>
<p>Whatever the decision is about the request type to use, this should only match what is needed and not the other one.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1868#pullrequestreview-120859003">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLZy19vltufqVdclFD6-gOWaOvnAtks5tzL45gaJpZM4UCMKT">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLW4WJYTAE_IrGHrVlbuQY_1JssABks5tzL45gaJpZM4UCMKT.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1868#pullrequestreview-120859003"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #1868"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1868#pullrequestreview-120859003"}}}</script>
<script type="application/ld+json">{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"@tomhughes requested changes on 1868","sections":[{"text":"In addition to the inline comments this needs some tests - at the very least the new route needs adding to the route tests in the user controller tests and there should be a test of the controller method as well.","activityTitle":"**Tom Hughes**","activityImage":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","activitySubtitle":"@tomhughes","facts":[]}],"potentialAction":[{"targets":[{"os":"default","uri":"https://github.com/openstreetmap/openstreetmap-website/pull/1868#pullrequestreview-120859003"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":336118419}"}],"themeColor":"26292E"}</script>