<p>Thanks <a class="user-mention" data-hovercard-user-id="3818" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/EdwardBetts">@EdwardBetts</a> ! This fixes a pet peeve of mine. There's lots more situations like this throughout the codebase, a simple search of <code>app/views</code> shows lots of label tags that aren't associated with any form fields. Even the ones that have "for" attributes are often wrong - e.g. app/views/user/new.html.erb where none of the label "for" attributes match the id of the form field. If you get the chance, fixing some of these, and moving them to rails tag helpers, would be appreciated too!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1880#issuecomment-391911628">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLRTzsIfy4eh4qPxhYvxAZKeGp74lks5t11pFgaJpZM4UMFqC">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLfLy1yl_xhzR_AAxLHxshfYMJnFQks5t11pFgaJpZM4UMFqC.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/openstreetmap/openstreetmap-website/pull/1880#issuecomment-391911628","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1880#issuecomment-391911628","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #1880: Thanks @EdwardBetts ! This fixes a pet peeve of mine. There's lots more situations like this throughout the codebase, a simple search of `app/views` shows lots of label tags that aren't associated with any form fields. Even the ones that have \"for\" attributes are often wrong - e.g. app/views/user/new.html.erb where none of the label \"for\" attributes match the id of the form field. If you get the chance, fixing some of these, and moving them to rails tag helpers, would be appreciated too!"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1880#issuecomment-391911628"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [openstreetmap/openstreetmap-website] Wrap the permission label with a \u003clabel\u003e tag (#1880)",
"sections": [
{
"text": "",
"activityTitle": "**Andy Allan**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@gravitystorm",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1880,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1880#issuecomment-391911628"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 338713218\n}"
}
],
"themeColor": "26292E"
}</script>