<p>This PR splits the trace creation into new and create methods, with standard resourceful routing. It provides a redirect for any external get requests to the old url. To prevent anyone from getting an error during deployment, the old POST target is honoured for now, but can be removed shortly after deployment since it's not an external url.</p>
<p><a class="user-mention" data-hovercard-user-id="1109395" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Nikerabbit">@Nikerabbit</a> this PR contains some translation key changes:</p>
<ul>
<li><code>traces.create.upload_trace</code>, <code>traces.create.trace_uploaded</code> and <code>traces.create.traces_waiting.*</code> remain as they were.</li>
<li>All other <code>traces.create.*</code> become <code>traces.new.*</code></li>
<li><code>traces.new.upload_trace</code> is a duplicate of the existing <code>traces.create.upload_trace</code></li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1892'>https://github.com/openstreetmap/openstreetmap-website/pull/1892</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Refactor trace creation pages</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-0">.rubocop_todo.yml</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-1">app/controllers/traces_controller.rb</a>
    (65)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-2">app/views/traces/list.html.erb</a>
    (4)
  </li>
  <li>
    <strong>R</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-3">app/views/traces/new.html.erb</a>
    (0)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-4">config/locales/en.yml</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-5">config/routes.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-6">test/controllers/traces_controller_test.rb</a>
    (26)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1892.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1892.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1892.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1892.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1892">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLSK6iIoMDluC0mCTCi66mcskBm9Jks5t50KegaJpZM4Ub5XH">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLRSE7bCAvn46Lh2SNURnSX6pu-o6ks5t50KegaJpZM4Ub5XH.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/openstreetmap/openstreetmap-website/pull/1892","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1892","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Refactor trace creation pages (#1892)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1892"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Refactor trace creation pages (#1892)",
"sections": [
{
"text": "",
"activityTitle": "**Andy Allan**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@gravitystorm",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "57d3b3a",
"value": "Refactor trace creation pages"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[.rubocop_todo.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-0) (2 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/traces_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-1) (65 changes)"
},
{
"name": "Modified",
"value": "[app/views/traces/list.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-2) (4 changes)"
},
{
"name": "Renamed",
"value": "[app/views/traces/new.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-3) (0 changes)"
},
{
"name": "Modified",
"value": "[config/locales/en.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-4) (12 changes)"
},
{
"name": "Modified",
"value": "[config/routes.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-5) (4 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/traces_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1892/files#diff-6) (26 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1892,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 1892\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1892"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1892.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1892.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 342857159\n}"
}
],
"themeColor": "26292E"
}</script>