<p>Making changes to evade ABP isn't something we should do. The block is against their policies, but that's up to the adblock developers.</p>
<p>Changing the ID of the announcement area is something we should consider - it's not really something I've ever thought about as a banner, so <code>#banner</code> stuff catches it unintentionally. Aren't we using the same div for downtime announcements?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1905#issuecomment-400513477">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLWHtXdp7D1Db9pdhRfB8wE20YpBRks5uAt9SgaJpZM4UtkTN">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLYine58lCvaTqYdX03lKG_cimErXks5uAt9SgaJpZM4UtkTN.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@pnorman in #1905: Making changes to evade ABP isn't something we should do. The block is against their policies, but that's up to the adblock developers.\r\n\r\nChanging the ID of the announcement area is something we should consider - it's not really something I've ever thought about as a banner, so `#banner` stuff catches it unintentionally. Aren't we using the same div for downtime announcements?\r\n\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1905#issuecomment-400513477"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1905#issuecomment-400513477",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1905#issuecomment-400513477",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] SotM 2018 banner (#1905)",
"sections": [
{
"text": "",
"activityTitle": "**Paul Norman**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@pnorman",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1905,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1905#issuecomment-400513477"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 347489485\n}"
}
],
"themeColor": "26292E"
}
]</script>