<p>I'm not sure to be honest - normally I would say one PR per feature but there's an obvious inclination here to put all the rubocop fixes together for example.</p>
<p>Except that I suspect we may not want some of those because they're mostly addressing things from the <code>.rubocop_todo.yml</code> and most of things that were left there were left because it was hard to decide whether the default style was right for us so just fixing everything to comply may not work very well.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-401405047">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLbt-NcBPf6HQodtlEO5235hIiaOyks5uBlTNgaJpZM4U9Kh6">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLeHRqSIahk9ggrnbrmq7QYK03-Oaks5uBlTNgaJpZM4U9Kh6.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes in #1918: I'm not sure to be honest - normally I would say one PR per feature but there's an obvious inclination here to put all the rubocop fixes together for example.\r\n\r\nExcept that I suspect we may not want some of those because they're mostly addressing things from the `.rubocop_todo.yml` and most of things that were left there were left because it was hard to decide whether the default style was right for us so just fixing everything to comply may not work very well."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-401405047"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-401405047",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-401405047",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] [Discussion] Refactors from RFG 2018 (#1918)",
"sections": [
{
"text": "",
"activityTitle": "**Tom Hughes**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@tomhughes",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1918,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 1918\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-401405047"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 351578234\n}"
}
],
"themeColor": "26292E"
}
]</script>