<p>This PR contains all of our larger refactor efforts from Ruby for Good 2018. Just oppening this PR to discuss some of the changes. Anything that individually looks good to merge as is we can cheery pick onto master.</p>
<p>Highlights indclude...</p>
<ol>
<li>Renaming some <code>view</code> controller actions to the more Rails standard <code>show</code></li>
<li>Rubocop fixes</li>
<li>Renaming <code>UserController</code> to more standard naming of <code>UsersController</code></li>
<li>Various other flattening of routes and steps toward a more resourceful routing strategy.</li>
</ol>
<p>Ill answer as many questions about these changes as I can, but feel free to also ping the original authors.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1918'>https://github.com/openstreetmap/openstreetmap-website/pull/1918</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Guard against undefined CSP_ENFORCE constant</li>
<li>Update .rubocop_todo.yml</li>
<li>Merge pull request #1 from rubyforgood/rubocop/auto_gen_config</li>
<li>Resolve 34 Rubocop Lint/AmbiguousOperator conflicts</li>
<li>Resolve 96 Rubocop Lint/AmbiguousRegexpLiteral conflicts</li>
<li>Resolve 2 Rubocop Lint/ShadowingOuterLocalVariable conflicts</li>
<li>Merge pull request #2 from rubyforgood/rubocop/lint_ambiguous_operator</li>
<li>Merge pull request #4 from rubyforgood/rubocop/lint_shadowing_out_local_variable</li>
<li>Merge branch 'master' into rubocop/lint_ambiguous_regex_literal</li>
<li>Merge pull request #3 from rubyforgood/rubocop/lint_ambiguous_regex_literal</li>
<li>Resolved 32 Rubocop/Lint/AssignmentInConditional</li>
<li>Bring up to date with current master</li>
<li>Update rubocop todo</li>
<li>Refactor where possible.</li>
<li>Update rubocop_todo.yml</li>
<li>A bit more refactoring.</li>
<li>change user#view to user#show</li>
<li>Merge pull request #5 from rubyforgood/rubucop_assignmentincondition</li>
<li>missed notifier model</li>
<li>Resolve if unless modifier offenses.</li>
<li>Resolve 5 Rubocop Style/RedundantBegin conflicts</li>
<li>Fix errant end of input</li>
<li>Merge branch 'master' into rubocop/style_redundant_begin</li>
<li>Fix error</li>
<li>Namespace api controller</li>
<li>Merge pull request #9 from rubyforgood/rubocop/if_unless_modifier_offenses</li>
<li>Run rubocop --auto-gen-config</li>
<li>Move api_controller route actions inside the "api/0.6" scope</li>
<li>Unflatten changeset routes</li>
<li>Split changeset controller in web controller and api controller</li>
<li>Move permissions jbuilder view inside the api folder</li>
<li>Remove actions from the before filter that don't live in the controller</li>
<li>Use nested module/class definitions instead of compact style</li>
<li>Merge branch 'master' into rubocop/style_redundant_begin</li>
<li>Merge pull request #10 from rubyforgood/refactor-api-routes-changeset</li>
<li>Merge branch 'master' into rubocop/style_redundant_begin</li>
<li>Merge pull request #6 from rubyforgood/usermess</li>
<li>Resolves 25 Rubocop Style/SafeNavigation conflicts</li>
<li>Merge pull request #8 from rubyforgood/rubocop/style_redundant_begin</li>
<li>Merge branch 'master' into rubocop/style_safe_navigation</li>
<li>Re-enable cop</li>
<li>Merge pull request #11 from rubyforgood/rubocop/style_safe_navigation</li>
<li>rename usercontroller to userscontroller</li>
<li>fix changeset and remove errant view</li>
<li>Merge pull request #13 from rubyforgood/reroute</li>
<li>Clear one style/if_unless_modifier rubocop offense</li>
<li>Merge pull request #14 from rubyforgood/rubocop_style/if_unless_modifier</li>
<li>Add begins back.</li>
<li>Set rubocop ruby version to 2.3.1 and update rubocop_todo.</li>
<li>Merge pull request #15 from rubyforgood/add_begins_back_and_disable_cop_to_support_ruby2.3.1</li>
<li>move the node controller to the Api module</li>
<li>Fix tests</li>
<li>Use nested module/class definitions instead of compact style</li>
<li>Specify the controller and action to be used when generating urls in the "feature.html.erb" view</li>
<li>Resolve 20 Rubocop Style/NumericPredicate conflicts</li>
<li>Fix failing tests</li>
<li>Update Rubocop exluded file name</li>
<li>Merge pull request #17 from rubyforgood/rubocop/style_numeric_predicate</li>
<li>Merge pull request #16 from rubyforgood/refactor-api-routes-node</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-0">.rubocop.yml</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-1">.rubocop_todo.yml</a>
(143)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-2">app/controllers/amf_controller.rb</a>
(22)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-3">app/controllers/api/api_controller.rb</a>
(314)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-4">app/controllers/api/changeset_controller.rb</a>
(364)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-5">app/controllers/api/node_controller.rb</a>
(77)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-6">app/controllers/api_controller.rb</a>
(312)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-7">app/controllers/application_controller.rb</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-8">app/controllers/browse_controller.rb</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-9">app/controllers/changeset_controller.rb</a>
(501)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-10">app/controllers/concerns/changesetable.rb</a>
(147)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-11">app/controllers/export_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-12">app/controllers/geocoder_controller.rb</a>
(17)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-13">app/controllers/messages_controller.rb</a>
(4)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-14">app/controllers/node_controller.rb</a>
(76)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-15">app/controllers/notes_controller.rb</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-16">app/controllers/old_controller.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-17">app/controllers/traces_controller.rb</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-18">app/controllers/user_preferences_controller.rb</a>
(3)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-19">app/controllers/users_controller.rb</a>
(118)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-20">app/controllers/way_controller.rb</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-21">app/helpers/application_helper.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-22">app/helpers/banner_helper.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-23">app/helpers/browse_helper.rb</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-24">app/helpers/changeset_helper.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-25">app/helpers/note_helper.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-26">app/helpers/notifier_helper.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-27">app/helpers/user_helper.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-28">app/helpers/user_roles_helper.rb</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-29">app/models/changeset.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-30">app/models/client_application.rb</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-31">app/models/notifier.rb</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-32">app/models/relation.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-33">app/models/trace.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-34">app/models/way.rb</a>
(4)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-35">app/views/api/api/permissions.builder</a>
(0)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-36">app/views/browse/changeset.html.erb</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-37">app/views/browse/feature.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-38">app/views/changeset/_user.atom.builder</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-39">app/views/changeset/history.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-40">app/views/changeset/list.atom.builder</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-41">app/views/diary_entry/view.html.erb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-42">app/views/layouts/_header.html.erb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-43">app/views/oauth/authorize.html.erb</a>
(2)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-44">app/views/users/_auth_association.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-45">app/views/users/_contact.html.erb</a>
(12)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-46">app/views/users/_popup.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-47">app/views/users/_terms.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-48">app/views/users/_user.html.erb</a>
(8)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-49">app/views/users/account.html.erb</a>
(10)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-50">app/views/users/api_read.builder</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-51">app/views/users/blocked.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-52">app/views/users/confirm.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-53">app/views/users/confirm_email.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-54">app/views/users/list.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-55">app/views/users/login.html.erb</a>
(4)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-56">app/views/users/logout.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-57">app/views/users/lost_password.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-58">app/views/users/make_friend.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-59">app/views/users/new.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-60">app/views/users/no_such_user.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-61">app/views/users/remove_friend.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-62">app/views/users/reset_password.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-63">app/views/users/show.html.erb</a>
(4)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-64">app/views/users/suspended.html.erb</a>
(0)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-65">app/views/users/terms.html.erb</a>
(0)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-66">config/initializers/secure_headers.rb</a>
(32)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-67">config/locales/af.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-68">config/locales/aln.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-69">config/locales/ar.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-70">config/locales/arz.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-71">config/locales/ast.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-72">config/locales/az.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-73">config/locales/be-Tarask.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-74">config/locales/be.yml</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-75">config/locales/bg.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-76">config/locales/bn.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-77">config/locales/br.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-78">config/locales/bs.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-79">config/locales/ca.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-80">config/locales/cs.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-81">config/locales/cy.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-82">config/locales/da.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-83">config/locales/de.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-84">config/locales/diq.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-85">config/locales/dsb.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-86">config/locales/el.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-87">config/locales/en-GB.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-88">config/locales/en.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-89">config/locales/eo.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-90">config/locales/es.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-91">config/locales/et.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-92">config/locales/eu.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-93">config/locales/fa.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-94">config/locales/fi.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-95">config/locales/fr.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-96">config/locales/fur.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-97">config/locales/fy.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-98">config/locales/ga.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-99">config/locales/gcf.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-100">config/locales/gd.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-101">config/locales/gl.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-102">config/locales/he.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-103">config/locales/hi.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-104">config/locales/hr.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-105">config/locales/hsb.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-106">config/locales/hu.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-107">config/locales/ia.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-108">config/locales/id.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-109">config/locales/is.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-110">config/locales/it.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-111">config/locales/ja.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-112">config/locales/ka.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-113">config/locales/kab.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-114">config/locales/km.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-115">config/locales/kn.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-116">config/locales/ko.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-117">config/locales/ksh.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-118">config/locales/ku-Latn.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-119">config/locales/lb.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-120">config/locales/lt.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-121">config/locales/lv.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-122">config/locales/mk.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-123">config/locales/mr.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-124">config/locales/ms.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-125">config/locales/nb.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-126">config/locales/nds.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-127">config/locales/ne.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-128">config/locales/nl.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-129">config/locales/nn.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-130">config/locales/oc.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-131">config/locales/pa.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-132">config/locales/pl.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-133">config/locales/ps.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-134">config/locales/pt-BR.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-135">config/locales/pt-PT.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-136">config/locales/pt.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-137">config/locales/ro.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-138">config/locales/ru.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-139">config/locales/scn.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-140">config/locales/sco.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-141">config/locales/sk.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-142">config/locales/sl.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-143">config/locales/sq.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-144">config/locales/sr-Latn.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-145">config/locales/sr.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-146">config/locales/sv.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-147">config/locales/ta.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-148">config/locales/te.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-149">config/locales/th.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-150">config/locales/tl.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-151">config/locales/tr.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-152">config/locales/uk.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-153">config/locales/vi.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-154">config/locales/yi.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-155">config/locales/yo.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-156">config/locales/zh-CN.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-157">config/locales/zh-TW.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-158">config/routes.rb</a>
(128)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-159">db/migrate/021_move_to_innodb.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-160">lib/classic_pagination/pagination.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-161">lib/daemons/gpx_import.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-162">lib/gpx.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-163">lib/nominatim.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-164">lib/osm.rb</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-165">script/deliver-message</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-166">test/controllers/amf_controller_test.rb</a>
(68)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-167">test/controllers/api/api_controller_test.rb</a>
(441)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-168">test/controllers/api/changeset_controller_test.rb</a>
(2186)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-169">test/controllers/api/node_controller_test.rb</a>
(553)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-170">test/controllers/api_controller_test.rb</a>
(436)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-171">test/controllers/changeset_controller_test.rb</a>
(2279)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-172">test/controllers/diary_entry_controller_test.rb</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-173">test/controllers/export_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-174">test/controllers/messages_controller_test.rb</a>
(6)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-175">test/controllers/node_controller_test.rb</a>
(551)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-176">test/controllers/old_node_controller_test.rb</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-177">test/controllers/redactions_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-178">test/controllers/relation_controller_test.rb</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-179">test/controllers/site_controller_test.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-180">test/controllers/swf_controller_test.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-181">test/controllers/traces_controller_test.rb</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-182">test/controllers/user_blocks_controller_test.rb</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-183">test/controllers/user_roles_controller_test.rb</a>
(4)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-184">test/controllers/users_controller_test.rb</a>
(156)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-185">test/integration/client_applications_test.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-186">test/integration/user_changeset_comments_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-187">test/integration/user_creation_test.rb</a>
(62)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-188">test/integration/user_diaries_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-189">test/integration/user_login_test.rb</a>
(168)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-190">test/integration/user_roles_test.rb</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-191">test/integration/user_terms_seen_test.rb</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-192">test/lib/bounding_box_test.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-193">test/lib/country_test.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-194">test/models/changeset_test.rb</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-195">test/models/message_test.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-196">test/models/node_test.rb</a>
(38)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-197">test/models/old_node_test.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-198">test/models/relation_test.rb</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-199">test/models/tracepoint_test.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-200">test/models/way_test.rb</a>
(22)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1918.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1918.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1918.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1918.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLd0v0-KNuxzc2eiYADLDCWDscUOTks5uBkCLgaJpZM4U9Kh6">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLZy3H7ueR_Vh0csWa7n2WEwOMf_Dks5uBkCLgaJpZM4U9Kh6.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"[Discussion] Refactors from RFG 2018 (#1918)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1918"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1918",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1918",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "[Discussion] Refactors from RFG 2018 (#1918)",
"sections": [
{
"text": "",
"activityTitle": "**Benjamin Reynolds**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@benreyn",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "84fa19f",
"value": "Guard against undefined CSP_ENFORCE constant"
},
{
"name": "40ff7d9",
"value": "Update .rubocop_todo.yml"
},
{
"name": "bf80c01",
"value": "Merge pull request #1 from rubyforgood/rubocop/auto_gen_config"
},
{
"name": "4448e82",
"value": "Resolve 34 Rubocop Lint/AmbiguousOperator conflicts"
},
{
"name": "21a7eb3",
"value": "Resolve 96 Rubocop Lint/AmbiguousRegexpLiteral conflicts"
},
{
"name": "19f9ed5",
"value": "Resolve 2 Rubocop Lint/ShadowingOuterLocalVariable conflicts"
},
{
"name": "911c847",
"value": "Merge pull request #2 from rubyforgood/rubocop/lint_ambiguous_operator"
},
{
"name": "e9f42f0",
"value": "Merge pull request #4 from rubyforgood/rubocop/lint_shadowing_out_local_variable"
},
{
"name": "3cde507",
"value": "Merge branch 'master' into rubocop/lint_ambiguous_regex_literal"
},
{
"name": "f2deaac",
"value": "Merge pull request #3 from rubyforgood/rubocop/lint_ambiguous_regex_literal"
},
{
"name": "9d8b6e3",
"value": "Resolved 32 Rubocop/Lint/AssignmentInConditional"
},
{
"name": "e8ab0cb",
"value": "Bring up to date with current master"
},
{
"name": "1f97197",
"value": "Update rubocop todo"
},
{
"name": "41c5834",
"value": "Refactor where possible."
},
{
"name": "dcc3f9d",
"value": "Update rubocop_todo.yml"
},
{
"name": "056524a",
"value": "A bit more refactoring."
},
{
"name": "9f52776",
"value": "change user#view to user#show"
},
{
"name": "93f9e30",
"value": "Merge pull request #5 from rubyforgood/rubucop_assignmentincondition"
},
{
"name": "f9f416b",
"value": "missed notifier model"
},
{
"name": "2843333",
"value": "Resolve if unless modifier offenses."
},
{
"name": "6d886a1",
"value": "Resolve 5 Rubocop Style/RedundantBegin conflicts"
},
{
"name": "9a18b7e",
"value": "Fix errant end of input"
},
{
"name": "e51922c",
"value": "Merge branch 'master' into rubocop/style_redundant_begin"
},
{
"name": "91c1124",
"value": "Fix error"
},
{
"name": "0b31769",
"value": "Namespace api controller"
},
{
"name": "e783ace",
"value": "Merge pull request #9 from rubyforgood/rubocop/if_unless_modifier_offenses"
},
{
"name": "f2e00cb",
"value": "Run rubocop --auto-gen-config"
},
{
"name": "dfea433",
"value": "Move api_controller route actions inside the \"api/0.6\" scope"
},
{
"name": "bd24128",
"value": "Unflatten changeset routes"
},
{
"name": "0b50d1b",
"value": "Split changeset controller in web controller and api controller"
},
{
"name": "b3ce189",
"value": "Move permissions jbuilder view inside the api folder"
},
{
"name": "f056ae8",
"value": "Remove actions from the before filter that don't live in the controller"
},
{
"name": "512a42c",
"value": "Use nested module/class definitions instead of compact style"
},
{
"name": "91eee35",
"value": "Merge branch 'master' into rubocop/style_redundant_begin"
},
{
"name": "973bb7a",
"value": "Merge pull request #10 from rubyforgood/refactor-api-routes-changeset"
},
{
"name": "6ad56f2",
"value": "Merge branch 'master' into rubocop/style_redundant_begin"
},
{
"name": "d706e24",
"value": "Merge pull request #6 from rubyforgood/usermess"
},
{
"name": "764f49e",
"value": "Resolves 25 Rubocop Style/SafeNavigation conflicts"
},
{
"name": "88f1ba4",
"value": "Merge pull request #8 from rubyforgood/rubocop/style_redundant_begin"
},
{
"name": "c0279fa",
"value": "Merge branch 'master' into rubocop/style_safe_navigation"
},
{
"name": "cd81b16",
"value": "Re-enable cop"
},
{
"name": "cf5a874",
"value": "Merge pull request #11 from rubyforgood/rubocop/style_safe_navigation"
},
{
"name": "14b81e4",
"value": "rename usercontroller to userscontroller"
},
{
"name": "3af8665",
"value": "fix changeset and remove errant view"
},
{
"name": "fb760e1",
"value": "Merge pull request #13 from rubyforgood/reroute"
},
{
"name": "c5a7e5a",
"value": "Clear one style/if_unless_modifier rubocop offense"
},
{
"name": "8850c13",
"value": "Merge pull request #14 from rubyforgood/rubocop_style/if_unless_modifier"
},
{
"name": "699e22c",
"value": "Add begins back."
},
{
"name": "60099a8",
"value": "Set rubocop ruby version to 2.3.1 and update rubocop_todo."
},
{
"name": "7888740",
"value": "Merge pull request #15 from rubyforgood/add_begins_back_and_disable_cop_to_support_ruby2.3.1"
},
{
"name": "5a2a81d",
"value": "move the node controller to the Api module"
},
{
"name": "055e371",
"value": "Fix tests"
},
{
"name": "788aef7",
"value": "Use nested module/class definitions instead of compact style"
},
{
"name": "e41aad5",
"value": "Specify the controller and action to be used when generating urls in the \"feature.html.erb\" view"
},
{
"name": "9d1d47a",
"value": "Resolve 20 Rubocop Style/NumericPredicate conflicts"
},
{
"name": "d062616",
"value": "Fix failing tests"
},
{
"name": "cc49204",
"value": "Update Rubocop exluded file name"
},
{
"name": "1ff3710",
"value": "Merge pull request #17 from rubyforgood/rubocop/style_numeric_predicate"
},
{
"name": "e671ab2",
"value": "Merge pull request #16 from rubyforgood/refactor-api-routes-node"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[.rubocop.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-0) (5 changes)"
},
{
"name": "Modified",
"value": "[.rubocop_todo.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-1) (143 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/amf_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-2) (22 changes)"
},
{
"name": "Added",
"value": "[app/controllers/api/api_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-3) (314 changes)"
},
{
"name": "Added",
"value": "[app/controllers/api/changeset_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-4) (364 changes)"
},
{
"name": "Added",
"value": "[app/controllers/api/node_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-5) (77 changes)"
},
{
"name": "Removed",
"value": "[app/controllers/api_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-6) (312 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/application_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-7) (22 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/browse_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-8) (10 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/changeset_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-9) (501 changes)"
},
{
"name": "Added",
"value": "[app/controllers/concerns/changesetable.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-10) (147 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/export_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-11) (2 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/geocoder_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-12) (17 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/messages_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-13) (4 changes)"
},
{
"name": "Removed",
"value": "[app/controllers/node_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-14) (76 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/notes_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-15) (15 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/old_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-16) (2 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/traces_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-17) (9 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/user_preferences_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-18) (3 changes)"
},
{
"name": "Renamed",
"value": "[app/controllers/users_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-19) (118 changes)"
},
{
"name": "Modified",
"value": "[app/controllers/way_controller.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-20) (8 changes)"
},
{
"name": "Modified",
"value": "[app/helpers/application_helper.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-21) (3 changes)"
},
{
"name": "Modified",
"value": "[app/helpers/banner_helper.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-22) (2 changes)"
},
{
"name": "Modified",
"value": "[app/helpers/browse_helper.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-23) (15 changes)"
},
{
"name": "Modified",
"value": "[app/helpers/changeset_helper.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-24) (2 changes)"
},
{
"name": "Modified",
"value": "[app/helpers/note_helper.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-25) (4 changes)"
},
{
"name": "Modified",
"value": "[app/helpers/notifier_helper.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-26) (2 changes)"
},
{
"name": "Modified",
"value": "[app/helpers/user_helper.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-27) (6 changes)"
},
{
"name": "Modified",
"value": "[app/helpers/user_roles_helper.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-28) (14 changes)"
},
{
"name": "Modified",
"value": "[app/models/changeset.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-29) (2 changes)"
},
{
"name": "Modified",
"value": "[app/models/client_application.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-30) (5 changes)"
},
{
"name": "Modified",
"value": "[app/models/notifier.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-31) (16 changes)"
},
{
"name": "Modified",
"value": "[app/models/relation.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-32) (4 changes)"
},
{
"name": "Modified",
"value": "[app/models/trace.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-33) (2 changes)"
},
{
"name": "Modified",
"value": "[app/models/way.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-34) (4 changes)"
},
{
"name": "Renamed",
"value": "[app/views/api/api/permissions.builder](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-35) (0 changes)"
},
{
"name": "Modified",
"value": "[app/views/browse/changeset.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-36) (14 changes)"
},
{
"name": "Modified",
"value": "[app/views/browse/feature.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-37) (2 changes)"
},
{
"name": "Modified",
"value": "[app/views/changeset/_user.atom.builder](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-38) (2 changes)"
},
{
"name": "Modified",
"value": "[app/views/changeset/history.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-39) (2 changes)"
},
{
"name": "Modified",
"value": "[app/views/changeset/list.atom.builder](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-40) (14 changes)"
},
{
"name": "Modified",
"value": "[app/views/diary_entry/view.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-41) (2 changes)"
},
{
"name": "Modified",
"value": "[app/views/layouts/_header.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-42) (6 changes)"
},
{
"name": "Modified",
"value": "[app/views/oauth/authorize.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-43) (2 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/_auth_association.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-44) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/_contact.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-45) (12 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/_popup.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-46) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/_terms.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-47) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/_user.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-48) (8 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/account.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-49) (10 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/api_read.builder](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-50) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/blocked.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-51) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/confirm.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-52) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/confirm_email.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-53) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/list.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-54) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/login.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-55) (4 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/logout.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-56) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/lost_password.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-57) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/make_friend.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-58) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/new.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-59) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/no_such_user.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-60) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/remove_friend.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-61) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/reset_password.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-62) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/show.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-63) (4 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/suspended.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-64) (0 changes)"
},
{
"name": "Renamed",
"value": "[app/views/users/terms.html.erb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-65) (0 changes)"
},
{
"name": "Modified",
"value": "[config/initializers/secure_headers.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-66) (32 changes)"
},
{
"name": "Modified",
"value": "[config/locales/af.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-67) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/aln.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-68) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ar.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-69) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/arz.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-70) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ast.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-71) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/az.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-72) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/be-Tarask.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-73) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/be.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-74) (6 changes)"
},
{
"name": "Modified",
"value": "[config/locales/bg.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-75) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/bn.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-76) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/br.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-77) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/bs.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-78) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ca.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-79) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/cs.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-80) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/cy.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-81) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/da.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-82) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/de.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-83) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/diq.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-84) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/dsb.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-85) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/el.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-86) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/en-GB.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-87) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/en.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-88) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/eo.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-89) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/es.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-90) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/et.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-91) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/eu.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-92) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/fa.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-93) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/fi.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-94) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/fr.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-95) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/fur.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-96) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/fy.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-97) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ga.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-98) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/gcf.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-99) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/gd.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-100) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/gl.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-101) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/he.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-102) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/hi.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-103) (2 changes)"
},
{
"name": "Modified",
"value": "[config/locales/hr.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-104) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/hsb.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-105) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/hu.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-106) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ia.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-107) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/id.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-108) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/is.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-109) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/it.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-110) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ja.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-111) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ka.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-112) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/kab.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-113) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/km.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-114) (2 changes)"
},
{
"name": "Modified",
"value": "[config/locales/kn.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-115) (2 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ko.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-116) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ksh.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-117) (2 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ku-Latn.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-118) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/lb.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-119) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/lt.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-120) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/lv.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-121) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/mk.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-122) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/mr.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-123) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ms.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-124) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/nb.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-125) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/nds.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-126) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ne.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-127) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/nl.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-128) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/nn.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-129) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/oc.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-130) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/pa.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-131) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/pl.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-132) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ps.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-133) (2 changes)"
},
{
"name": "Modified",
"value": "[config/locales/pt-BR.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-134) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/pt-PT.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-135) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/pt.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-136) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ro.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-137) (2 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ru.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-138) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/scn.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-139) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/sco.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-140) (2 changes)"
},
{
"name": "Modified",
"value": "[config/locales/sk.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-141) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/sl.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-142) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/sq.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-143) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/sr-Latn.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-144) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/sr.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-145) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/sv.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-146) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/ta.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-147) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/te.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-148) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/th.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-149) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/tl.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-150) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/tr.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-151) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/uk.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-152) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/vi.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-153) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/yi.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-154) (2 changes)"
},
{
"name": "Modified",
"value": "[config/locales/yo.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-155) (2 changes)"
},
{
"name": "Modified",
"value": "[config/locales/zh-CN.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-156) (4 changes)"
},
{
"name": "Modified",
"value": "[config/locales/zh-TW.yml](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-157) (4 changes)"
},
{
"name": "Modified",
"value": "[config/routes.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-158) (128 changes)"
},
{
"name": "Modified",
"value": "[db/migrate/021_move_to_innodb.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-159) (2 changes)"
},
{
"name": "Modified",
"value": "[lib/classic_pagination/pagination.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-160) (2 changes)"
},
{
"name": "Modified",
"value": "[lib/daemons/gpx_import.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-161) (2 changes)"
},
{
"name": "Modified",
"value": "[lib/gpx.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-162) (2 changes)"
},
{
"name": "Modified",
"value": "[lib/nominatim.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-163) (3 changes)"
},
{
"name": "Modified",
"value": "[lib/osm.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-164) (5 changes)"
},
{
"name": "Modified",
"value": "[script/deliver-message](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-165) (6 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/amf_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-166) (68 changes)"
},
{
"name": "Added",
"value": "[test/controllers/api/api_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-167) (441 changes)"
},
{
"name": "Added",
"value": "[test/controllers/api/changeset_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-168) (2186 changes)"
},
{
"name": "Added",
"value": "[test/controllers/api/node_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-169) (553 changes)"
},
{
"name": "Removed",
"value": "[test/controllers/api_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-170) (436 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/changeset_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-171) (2279 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/diary_entry_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-172) (18 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/export_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-173) (2 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/messages_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-174) (6 changes)"
},
{
"name": "Removed",
"value": "[test/controllers/node_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-175) (551 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/old_node_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-176) (14 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/redactions_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-177) (2 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/relation_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-178) (10 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/site_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-179) (4 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/swf_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-180) (6 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/traces_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-181) (10 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/user_blocks_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-182) (12 changes)"
},
{
"name": "Modified",
"value": "[test/controllers/user_roles_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-183) (4 changes)"
},
{
"name": "Renamed",
"value": "[test/controllers/users_controller_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-184) (156 changes)"
},
{
"name": "Modified",
"value": "[test/integration/client_applications_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-185) (6 changes)"
},
{
"name": "Modified",
"value": "[test/integration/user_changeset_comments_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-186) (2 changes)"
},
{
"name": "Modified",
"value": "[test/integration/user_creation_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-187) (62 changes)"
},
{
"name": "Modified",
"value": "[test/integration/user_diaries_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-188) (2 changes)"
},
{
"name": "Modified",
"value": "[test/integration/user_login_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-189) (168 changes)"
},
{
"name": "Modified",
"value": "[test/integration/user_roles_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-190) (8 changes)"
},
{
"name": "Modified",
"value": "[test/integration/user_terms_seen_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-191) (12 changes)"
},
{
"name": "Modified",
"value": "[test/lib/bounding_box_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-192) (4 changes)"
},
{
"name": "Modified",
"value": "[test/lib/country_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-193) (6 changes)"
},
{
"name": "Modified",
"value": "[test/models/changeset_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-194) (12 changes)"
},
{
"name": "Modified",
"value": "[test/models/message_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-195) (4 changes)"
},
{
"name": "Modified",
"value": "[test/models/node_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-196) (38 changes)"
},
{
"name": "Modified",
"value": "[test/models/old_node_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-197) (4 changes)"
},
{
"name": "Modified",
"value": "[test/models/relation_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-198) (22 changes)"
},
{
"name": "Modified",
"value": "[test/models/tracepoint_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-199) (4 changes)"
},
{
"name": "Modified",
"value": "[test/models/way_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/1918/files#diff-200) (22 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1918,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 1918\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1918"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1918.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1918.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 351578234\n}"
}
],
"themeColor": "26292E"
}
]</script>