<p><b>@datendelphin</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1914#discussion_r200046060">test/integration/user_membership_test.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,67 @@
+require "test_helper"
</pre>
<p>I could split it in to 3 functions or files easily:</p>
<ul>
<li>check that badge is not shown on user page by default</li>
<li>enable "show" of the OSMF membership, test that checkbox is shown; check that badge is shown on user page</li>
<li>make sure that non member does not get the checkbox and post (submit setting "show osmf membership") has no effect: check that badge is not shown on user page<br>
Is that what you have in mind? Functions or Files?</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1914#discussion_r200046060">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLfFqoEv9dOxSc5RDUXJorLi7uLglks5uDHwHgaJpZM4U1H6q">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLVdq0xYNDAIIhhxih2I5ysSCu3SYks5uDHwHgaJpZM4U1H6q.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@datendelphin commented on #1914"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1914#discussion_r200046060"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1914#discussion_r200046060",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1914#discussion_r200046060",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@datendelphin commented on 1914",
"sections": [
{
"text": "",
"activityTitle": "**datendelphin**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@datendelphin",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1914#discussion_r200046060"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 349470378\n}"
}
],
"themeColor": "26292E"
}
]</script>