<blockquote>
<p>The key thing is not removing the translations from application.js</p>
</blockquote>
<p>I disagree. I tried to take the discussion one step further - rather than just "we need to send the translations more efficiently" I tried to examine whether we need to send these translations at all. I'd like to see a compelling reason for doing all this client-side instead of server-side.</p>
<blockquote>
<p>Your other suggestion appears to be going in the opposite direction of what I understood to be our direction of travel, by moving things from the client to the server.</p>
</blockquote>
<p>I don't know whether there's a direction of travel or not, and I don't have a strong opinion on that. But in my investigations so far it appears that buildling small html pages client-side has moderately large downsides. Again it might not be so noticeable on fast connections in Europe, but when a simple browse page takes multiple EU <-> HK roundtrips it becomes noticeable to me - even on a high bandwidth connection. I expect it will be much worse on low-bandwidth, high-latency connections elsewhere.</p>
<blockquote>
<p>I'm really reluctant to be tying up server resources on something like that which can be relatively long running</p>
</blockquote>
<p>I don't think putting together the browse or query pages server-side will actually be that expensive, but that's definitely a risk. From what I've seen so far, making one request and getting the compact html in response is going to be much better than multiple xhr back-and-forwards and large json payload responses.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/1949#issuecomment-413525254">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLX6T5RcfR9DQM-1wq_7JewRt4S5Qks5uRWIxgaJpZM4V_j_f">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLaY1_g5zQkn-k8TKAonTvCGRhblrks5uRWIxgaJpZM4V_j_f.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #1949: \u003e The key thing is not removing the translations from application.js\r\n\r\nI disagree. I tried to take the discussion one step further - rather than just \"we need to send the translations more efficiently\" I tried to examine whether we need to send these translations at all. I'd like to see a compelling reason for doing all this client-side instead of server-side.\r\n\r\n\u003e Your other suggestion appears to be going in the opposite direction of what I understood to be our direction of travel, by moving things from the client to the server.\r\n\r\nI don't know whether there's a direction of travel or not, and I don't have a strong opinion on that. But in my investigations so far it appears that buildling small html pages client-side has moderately large downsides. Again it might not be so noticeable on fast connections in Europe, but when a simple browse page takes multiple EU \u003c-\u003e HK roundtrips it becomes noticeable to me - even on a high bandwidth connection. I expect it will be much worse on low-bandwidth, high-latency connections elsewhere.\r\n\r\n\u003e I'm really reluctant to be tying up server resources on something like that which can be relatively long running\r\n\r\nI don't think putting together the browse or query pages server-side will actually be that expensive, but that's definitely a risk. From what I've seen so far, making one request and getting the compact html in response is going to be much better than multiple xhr back-and-forwards and large json payload responses."}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/1949#issuecomment-413525254"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/1949#issuecomment-413525254",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/1949#issuecomment-413525254",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] Reduce size of application.js by removing translations? (#1949)",
"sections": [
{
"text": "",
"activityTitle": "**Andy Allan**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@gravitystorm",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1949,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1949\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/issues/1949#issuecomment-413525254"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 368984031\n}"
}
],
"themeColor": "26292E"
}
]</script>