<p><b>@ENT8R</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1955#discussion_r212993534">test/controllers/notes_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -876,6 +876,45 @@ def test_search_success
end
end
+ def test_search_by_user_success
</pre>
<p>Nope. Also not yet <g-emoji class="g-emoji" alias="smile" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f604.png">😄</g-emoji> This might be the reason why the coverage decreased... <g-emoji class="g-emoji" alias="arrow_down_small" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f53d.png">🔽</g-emoji><br>
I will add another test.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1955#discussion_r212993534">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLTeVSDfqZ3iyjDxII2Nlh-9SPO_bks5uVADSgaJpZM4WMidA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLW4CybjkgIhr9QS2BTwjr8V72Hwgks5uVADSgaJpZM4WMidA.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ENT8R commented on #1955"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1955#discussion_r212993534"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1955#discussion_r212993534",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1955#discussion_r212993534",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ENT8R commented on 1955",
"sections": [
{
"text": "",
"activityTitle": "**ENT8R**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ENT8R",
"facts": [
]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1955#discussion_r212993534"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 372385600\n}"
}
],
"themeColor": "26292E"
}
]</script>