<p>There's was a lot of fixup commits, and branch merges seem to have confused either me or github or both. So I've gone through all the commits to make a summary of what different topics were covered in here:</p>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Refactor api methods into their own namespaced controllers (e.g. app/controllers/api/nodes_controller.rb)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Rubocop numeric predicates (foo < 0  becomes foo.negative?)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Resourceful naming for nodes_controller</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Rubocop if/unless modifier</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Rename usercontroller to userscontroller</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Resourceful naming for userscontroller</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Rubocop safe navigation</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Rubocop assignment in condition</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Rubocop ambiguous regexp literal</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Rubocop shadowingouterlocalvariable</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Rubocop ambiguous operator</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox">  Guard against undefined CSP_ENFORCE constant</li>
</ul>
<p>I plan to work through this list, split some straightforward things off into their own PRs and then see what we're left with!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-419763898">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLWwIPjvnvcDqDGNWsug1wUCA_AZ8ks5uZcN3gaJpZM4U9Kh6">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLacutgL5LcyCITjW717z-HDwu0wpks5uZcN3gaJpZM4U9Kh6.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #1918: There's was a lot of fixup commits, and branch merges seem to have confused either me or github or both. So I've gone through all the commits to make a summary of what different topics were covered in here:\r\n\r\n- [ ]  Refactor api methods into their own namespaced controllers (e.g. app/controllers/api/nodes_controller.rb)\r\n- [ ]  Rubocop numeric predicates (foo \u003c 0  becomes foo.negative?)\r\n- [ ]  Resourceful naming for nodes_controller\r\n- [ ]  Rubocop if/unless modifier\r\n- [ ]  Rename usercontroller to userscontroller\r\n- [ ]  Resourceful naming for userscontroller\r\n- [ ]  Rubocop safe navigation\r\n- [ ]  Rubocop assignment in condition\r\n- [ ]  Rubocop ambiguous regexp literal\r\n- [ ]  Rubocop shadowingouterlocalvariable\r\n- [ ]  Rubocop ambiguous operator\r\n- [ ]  Guard against undefined CSP_ENFORCE constant\r\n\r\nI plan to work through this list, split some straightforward things off into their own PRs and then see what we're left with!"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-419763898"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-419763898",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-419763898",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] [Discussion] Refactors from RFG 2018 (#1918)",
"sections": [
{
"text": "",
"activityTitle": "**Andy Allan**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@gravitystorm",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1918,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 1918\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-419763898"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 351578234\n}"
}
],
"themeColor": "26292E"
}
]</script>