<p><b>@mmd-osm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1990#discussion_r216451458">app/assets/javascripts/index.js</a>:</p>
<pre style='color:#555'>> @@ -187,8 +187,10 @@ $(document).ready(function () {
$.cookie('_osm_location', OSM.locationCookie(map), { expires: expiry, path: '/' });
});
- if ($.cookie('_osm_welcome') === 'hide') {
- $('.welcome').hide();
+ if ($.cookie('_osm_welcome') !== 'hide' &&
+ (typeof window.matchMedia !== "function" ||
+ !window.matchMedia("only screen and (max-width:768px)").matches)) {
</pre>
<p>Sure. This may really be kind of an overkill, and it's only useful for mobile devices anyway. I'm perfectly fine to remove those two lines 191+192 again. Their only purpose is to skip <code>$('.welcome').show()</code>, if the screen is too small.</p>
<p>Reason being that small.scss defines the following <code>display:none</code> with <code>!important</code>. So whatever we try to do in terms of show(), it gets overruled immediately (with some flickering on the mobile screen again).</p>
<pre><code> #sidebar .welcome,
#sidebar #banner {
display: none !important;
}
</code></pre>
<p>According to <a href="https://developer.mozilla.org/en-US/docs/Web/API/Window/matchMedia#Browser_compatibility" rel="nofollow">https://developer.mozilla.org/en-US/docs/Web/API/Window/matchMedia#Browser_compatibility</a>, window.matchMedia support is quite good. Line 191 should cover those browsers, where it's not yet supported.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1990#discussion_r216451458">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLW8-ijWehXDijtRQb7X4dL2OZOLpks5uZsM-gaJpZM4WiAj5">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLTSnXnY_31KGEPokZSlW7ZeqyX4yks5uZsM-gaJpZM4WiAj5.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mmd-osm commented on #1990"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1990#discussion_r216451458"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1990#discussion_r216451458",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1990#discussion_r216451458",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@mmd-osm commented on 1990",
"sections": [
{
"text": "",
"activityTitle": "**mmd**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@mmd-osm",
"facts": [
]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1990#discussion_r216451458"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 378013945\n}"
}
],
"themeColor": "26292E"
}
]</script>