<p>It's pretty much the same performance optimization I described in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="284125414" data-permission-text="Issue title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/1710" href="https://github.com/openstreetmap/openstreetmap-website/issues/1710">#1710</a> and also implemented in cgimap. I tested a few easy cases via url rewriting (upload --> bulk_upload), and they seemed ok. The current code seems to be duplicating quite a lot of stuff, i.e. <a class="user-mention" data-hovercard-user-id="360803" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> probably wants to to through the code.</p>
<p>The general concept of bundling many small sql statments into larger ones works, regardless of which language issues the requests. Still there's some more overhead in Rails processing (about factor 5 in one test case).</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-422171257">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLeUyzDt_iPF1781zVzC4EaClLCkCks5ucA6zgaJpZM4WsA9n">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLRR9t8PWpKRTBfl3Zsg3DsMqtZaAks5ucA6zgaJpZM4WsA9n.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mmd-osm in #1995: It's pretty much the same performance optimization I described in https://github.com/openstreetmap/openstreetmap-website/issues/1710 and also implemented in cgimap. I tested a few easy cases via url rewriting (upload --\u003e bulk_upload), and they seemed ok. The current code seems to be duplicating quite a lot of stuff, i.e. @gravitystorm probably wants to to through the code.\r\n\r\nThe general concept of bundling many small sql statments into larger ones works, regardless of which language issues the requests. Still there's some more overhead in Rails processing (about factor 5 in one test case)."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-422171257"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-422171257",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-422171257",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] add bulk_upload (#1995)",
"sections": [
{
"text": "",
"activityTitle": "**mmd**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@mmd-osm",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1995,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 1995\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-422171257"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 380637031\n}"
}
],
"themeColor": "26292E"
}
]</script>