<blockquote>
<p>Well my point was why is there nothing in the PR to explain what it's about? or even in the commit messages...</p>
<p>Above all else, if it's just optimisations why is it a new method rather then just improving the existing method?</p>
</blockquote>
<p>Sorry for making you confused, I will write some descriptions later...<br>
The new bulk_upload method is slightly different from old upload method on response in some case, but won't break original logic. If it's OK, I will make a commit to replace the old one. Thanks!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-422227372">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLbCkBKaTc_1YEy7YflSFTQ0APokbks5ucFJ1gaJpZM4WsA9n">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLQTfYhveCPBnXu6a-sM2TeoB8cAtks5ucFJ1gaJpZM4WsA9n.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jiaxuyang in #1995: \u003e Well my point was why is there nothing in the PR to explain what it's about? or even in the commit messages...\r\n\u003e \r\n\u003e Above all else, if it's just optimisations why is it a new method rather then just improving the existing method?\r\n\r\nSorry for making you confused, I will write some descriptions later...\r\nThe new bulk_upload method is slightly different from old upload method on response in some case, but won't break original logic. If it's OK, I will make a commit to replace the old one. Thanks!"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-422227372"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-422227372",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-422227372",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] add bulk_upload (#1995)",
"sections": [
{
"text": "",
"activityTitle": "**Xuyang Jia**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@jiaxuyang",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1995,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 1995\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/1995#issuecomment-422227372"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 380637031\n}"
}
],
"themeColor": "26292E"
}
]</script>