<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2006#discussion_r220581073">test/controllers/notes_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -121,7 +121,11 @@ def test_routes
 
     assert_routing(
       { :path => "/user/username/notes", :method => :get },
-      { :controller => "notes", :action => "mine", :display_name => "username" }
+      { :controller => "notes", :action => "user", :display_name => "username" }
+    )
+    assert_routing(
+      { :path => "/traces/mine", :method => :get },
+      { :controller => "traces", :action => "mine" }
</pre>
<p>I think you mean <code>notes</code> here ;-)</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2006#discussion_r220583427">app/controllers/notes_controller.rb</a>:</p>
<pre style='color:#555'>>      if params[:display_name]
       if @user = User.active.find_by(:display_name => params[:display_name])
         @params = params.permit(:display_name)
-        @title = t "notes.mine.title", :user => @user.display_name
-        @heading = t "notes.mine.heading", :user => @user.display_name
+
+        # set title/heading
+        if current_user && current_user.display_name == @user.display_name
+          @title = t "user.show.my notes"
+          @heading = t "user.show.my notes"
</pre>
<p>I know that traces does something similar, but I wonder if this is sensible/worthwhile...</p>
<p>I mean <code>/mine</code> is basically a shortcut to asking for a particular user that isn't even preserved in the URL because we redirect, so giving this page a different title if you're logged in seems a little odd and not really necessary?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2006#pullrequestreview-159019716">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLXxky84-UjvvTrBeH8cZbN-_f5h5ks5ue42agaJpZM4W6wQf">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLVL2NvAwc4EF-l0_HqNkA6TPUD16ks5ue42agaJpZM4W6wQf.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #2006"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2006#pullrequestreview-159019716"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2006#pullrequestreview-159019716",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2006#pullrequestreview-159019716",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@tomhughes requested changes on 2006",
"sections": [
{
"text": "",
"activityTitle": "**Tom Hughes**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@tomhughes",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2006#pullrequestreview-159019716"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 384500767\n}"
}
],
"themeColor": "26292E"
}
]</script>