<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=147741" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tomhughes">@tomhughes</a></p>
<p>How should the actual changeset rendering be handled, once the link has been clicked through from the history page. At the moment, its still the minimum size: <a href="https://www.openstreetmap.org/changeset/63058122" rel="nofollow">https://www.openstreetmap.org/changeset/63058122</a></p>
<p>From what I can tell, the changeset is rendered automatically using internal Leaflet GeoJSON code, based on data returned from the OSM API. So the API returns the tiny changeset bounds, and GeoJSON renders it automatically.</p>
<p>So to fix it, the actual data from the API has to be manipulated, either in the controller (so if the changeset has equal minlat/maxlat or minlon/maxlon values, then a minimum sized changeset is sent back instead), or by manipulating the xml data that is returned.</p>
<p>How would you handle it? Is it worth changing the API output so that the minimum changeset bounds are changed in the data layer before being sent back from the API, rather than being manipulated in the view layer?</p>
<p>Or should it just be left as it is and ignored for now?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2010#issuecomment-426852299">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLWCbvaElBqifLqae0h3S-7h7u1JMks5uhV8igaJpZM4XFArm">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLU6AIkAmI0mBTn0Kr6-kJZjE9Cclks5uhV8igaJpZM4XFArm.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jguthrie100 in #2010: @tomhughes \r\n\r\nHow should the actual changeset rendering be handled, once the link has been clicked through from the history page. At the moment, its still the minimum size: https://www.openstreetmap.org/changeset/63058122\r\n\r\nFrom what I can tell, the changeset is rendered automatically using internal Leaflet GeoJSON code, based on data returned from the OSM API. So the API returns the tiny changeset bounds, and GeoJSON renders it automatically.\r\n\r\nSo to fix it, the actual data from the API has to be manipulated, either in the controller (so if the changeset has equal minlat/maxlat or minlon/maxlon values, then a minimum sized changeset is sent back instead), or by manipulating the xml data that is returned.\r\n\r\nHow would you handle it? Is it worth changing the API output so that the minimum changeset bounds are changed in the data layer before being sent back from the API, rather than being manipulated in the view layer?\r\n\r\nOr should it just be left as it is and ignored for now?"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2010#issuecomment-426852299"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2010#issuecomment-426852299",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2010#issuecomment-426852299",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] Set minimum changeset boundary size (#2010)",
"sections": [
{
"text": "",
"activityTitle": "**Jamie Guthrie**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@jguthrie100",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2010,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2010#issuecomment-426852299"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 387189478\n}"
}
],
"themeColor": "26292E"
}
]</script>