<blockquote>
<p>but nothing ever sets that attribute</p>
</blockquote>
<p>Well, skip_uniqueness actually gets set for each tracepoint we add to <code>tps</code> by setting <code>tp.skip_uniqueness = true</code>.</p>
<blockquote>
<p>If it is "pointless" as you suggest then why not get rid of it</p>
</blockquote>
<p>Pointless was more meant in a sense, that we're running the following 2 SELECTs for <em>each single GPS point</em>. Obviously this is a bit of a waste, as the trace file id, as well as the users id will be identical all the time. Assuming <code>tp.gpx_id = id</code> uses the correct id, there's no point checking this over and over.</p>
<pre><code>SELECT  "gpx_files".* FROM "gpx_files" WHERE "gpx_files"."id" = $1 LIMIT $2  [["id", 21], ["LIMIT", 1]]
SELECT  "users".* FROM "users" WHERE "users"."id" = $1 LIMIT $2  [["id", 1], ["LIMIT", 1]]
</code></pre>
<p>By the way, maybe the change to trace.rb above will not be needed, once the <em>tracepoint --> trace</em> validation is disabled.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/1852#issuecomment-426975215">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLSCKCsclzWryczuup45dLS6Wous7ks5uhem6gaJpZM4T3-LP">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLaT7RUjAWP_u4oaN4Z1cU6kF3Fw5ks5uhem6gaJpZM4T3-LP.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mmd-osm in #1852: \u003e  but nothing ever sets that attribute\r\n\r\nWell, skip_uniqueness actually gets set for each tracepoint we add to `tps` by setting `tp.skip_uniqueness = true`.\r\n\r\n\u003e If it is \"pointless\" as you suggest then why not get rid of it\r\n\r\nPointless was more meant in a sense, that we're running the following 2 SELECTs for _each single GPS point_. Obviously this is a bit of a waste, as the trace file id, as well as the users id will be identical all the time. Assuming `tp.gpx_id = id` uses the correct id, there's no point checking this over and over.\r\n\r\n```\r\nSELECT  \"gpx_files\".* FROM \"gpx_files\" WHERE \"gpx_files\".\"id\" = $1 LIMIT $2  [[\"id\", 21], [\"LIMIT\", 1]]\r\nSELECT  \"users\".* FROM \"users\" WHERE \"users\".\"id\" = $1 LIMIT $2  [[\"id\", 1], [\"LIMIT\", 1]]\r\n```\r\n\r\nBy the way, maybe the change to trace.rb above will not be needed, once the _tracepoint --\u003e trace_ validation is disabled.\r\n\r\n"}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/1852#issuecomment-426975215"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/1852#issuecomment-426975215",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/1852#issuecomment-426975215",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] Integrate the high-performance GPX importer (#1852)",
"sections": [
{
"text": "",
"activityTitle": "**mmd**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@mmd-osm",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1852,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 1852\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/issues/1852#issuecomment-426975215"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 333439695\n}"
}
],
"themeColor": "26292E"
}
]</script>