<p><b>@tomhughes</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2019#discussion_r223208591">app/controllers/application_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -134,6 +134,20 @@ def require_moderator
end
end
+ ##
+ # require that the user is a administrator, or fill out a helpful error message
+ # and return them to the user/login page.
+ def require_administrator
+ if current_user
+ unless current_user.administrator?
+ flash[:error] = t("user.filter.not_an_administrator")
</pre>
<p>That needs to be <code>users.filter.not_an_administrator</code> as that key doesn't exist - looks like you chose to copy the one that is broken since <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=360803" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> renamed <code>user</code> to <code>users</code> last week ;-)</p>
<p>The <code>user_role</code> version can also be removed from <code>config/locales/en.yml</code> as it will no longer be used once this is merged.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2019#pullrequestreview-162285706">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLTrFcxqlukeUHEaoDascdiLlgZqdks5uidwBgaJpZM4XLwZ0">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLe8sqvRZp9VhfSTwCjThetE1JZP5ks5uidwBgaJpZM4XLwZ0.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #2019"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2019#pullrequestreview-162285706"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2019#pullrequestreview-162285706",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2019#pullrequestreview-162285706",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@tomhughes requested changes on 2019",
"sections": [
{
"text": "",
"activityTitle": "**Tom Hughes**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@tomhughes",
"facts": [
]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2019#pullrequestreview-162285706"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 388957812\n}"
}
],
"themeColor": "26292E"
}
]</script>