<p>I have originally sparsely used OpenStreetMap's changeset comment feature. But few days ago, I have a run-in with commercial OSM (armchair) mapper which prompted me to leave a many-paragraph long comment explaining how exactly the changed features mismatched what's in the field.</p>
<p>But once I submitted the comments, OpenStreetMap.org's changeset discussion interface <strong>simply shown my comments as big jumbles of text</strong>, with no distinction where each paragraph started or ended; ended up making them very difficult to read and interpret:</p>
<ul>
<li><a href="https://www.openstreetmap.org/changeset/62658038" rel="nofollow">The changeset discussion in question</a></li>
<li><a href="https://u.cubeupload.com/xwindows/35JxYd.png" rel="nofollow">Changeset discussion screenshot</a></li>
</ul>
<p>A quick view of the page with CSS turned off revealed that HTML <code><p></code> paragraphs are indeed intact (and the thread became much more readable). This shows that CSS is the culprit:</p>
<ul>
<li><a href="https://u.cubeupload.com/xwindows/8ZUCL5.png" rel="nofollow">Changeset discussion screenshot (with CSS turned off)</a></li>
</ul>
<p>According to <em>Inspect</em> tool on my browser, the problem rooted from the first ruleset at the beginning of <a href="https://www.openstreetmap.org/assets/screen-ltr-f0481d92f08111394761c5e32410e85988b21dda874cd0fbf9846e9f62f5cd86.css" rel="nofollow"><code>screen-ltr-*.css</code></a>, which disables margin of paragraph tags with nothing else to re-enable it:</p>
<ul>
<li><a href="https://u.cubeupload.com/xwindows/woCv6R.png" rel="nofollow">Screenshot of Inspect tool on changeset discussion</a></li>
<li><a href="https://u.cubeupload.com/xwindows/QDus7V.png" rel="nofollow">Screenshot of Inspect tool when the <code>margin: 0px</code> rule is temporarily disabled</a>; you would see that the paragraph spacing now appears, though with some side effects on the top bar.</li>
<li><a href="https://u.cubeupload.com/xwindows/8a1iBu.png" rel="nofollow">Screenshot of changeset discussion when the <code>margin: 0px</code> rule is temporarily disabled</a>; you would see that the comment is now much easier to read.</li>
</ul>
<p>A solution could be creating a separate ruleset that specially targets <code><p></code> tag inside a block with <code>changeset-comments</code> class; then add <code>margin-bottom</code> style with appropriate size to it, maybe with <code>!important</code> override too.</p>
<p>Please investigate and fix; the changeset discussion is likely to become much more conductive if this is fixed.</p>
<p>Browser: Pale Moon 25.8.1 (GNU/Linux 32-bit)</p>
<p><strong>Notes:</strong></p>
<ul>
<li>While I'm not sure if this also affect note comments or not (since I don't leave a very long comment on notes), <strong>a look on <em>Inspector</em> tool strongly suggests that it is also the case</strong>. The fix would be the same (but its parent block was marked with <code>note-comments</code> class rather than <code>changeset-comments</code> class).</li>
<li>This bug does not affect the notification emails; the changeset comments look fine and readable there.</li>
<li>This is not browser-specific, the lack of paragraph spacing is also reproducible on Opera 11.64 (Win32).</li>
<li>If I remembered correctly, this bug exists since the first time I used OpenStreetMap's changeset discussion feature <a href="https://www.openstreetmap.org/changeset/56374444" rel="nofollow">on 21-Feb-2018</a>.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/2022">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLfBWmDVtVtiyTvjvajoxyPLYDk_7ks5ujKfdgaJpZM4XTT5O">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLXCVh8NWoDQ2dNETD-9w9DURBzZ8ks5ujKfdgaJpZM4XTT5O.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"There should be space between paragraphs in changeset comment display (#2022)"}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/2022"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/2022",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/2022",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "There should be space between paragraphs in changeset comment display (#2022)",
"sections": [
{
"text": "",
"activityTitle": "**Nutchanon Wetchasit**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@nachanon",
"facts": [
{
"name": "Repository: ",
"value": "openstreetmap/openstreetmap-website"
},
{
"name": "Issue #: ",
"value": 2022
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2022,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2022\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/issues/2022"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 390938190\n}"
}
],
"themeColor": "26292E"
}
]</script>