<p>I confess that I don't really understand the notes feed, and I'm not sure who uses it and what for so I'm finding it hard to evaluate this.</p>
<p>The core problem is that it's a feed of notes but it is triggered by comments so that notes reappear when they have a new comment right? But it has this weird dual thing of showing both the latest comment (that caused it to be included) and the whole thread?</p>
<p>But it seems to me that you change doesn't really fix that because we still get the duplication the second time round - why is it a problem for a new note and not for subsequent comments?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431702156">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLSn4MW4gZxC6xZYyN_oSu5ups0OFks5unNumgaJpZM4XyAW2">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLQ4rtO5HCYrOPFaPjT9RNDecJfRxks5unNumgaJpZM4XyAW2.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes in #2029: I confess that I don't really understand the notes feed, and I'm not sure who uses it and what for so I'm finding it hard to evaluate this.\r\n\r\nThe core problem is that it's a feed of notes but it is triggered by comments so that notes reappear when they have a new comment right? But it has this weird dual thing of showing both the latest comment (that caused it to be included) and the whole thread?\r\n\r\nBut it seems to me that you change doesn't really fix that because we still get the duplication the second time round - why is it a problem for a new note and not for subsequent comments?"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431702156"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431702156",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431702156",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] Don't duplicate note comments in RSS feeds for new notes (#2029)",
"sections": [
{
"text": "",
"activityTitle": "**Tom Hughes**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@tomhughes",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2029,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 2029\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431702156"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 398984630\n}"
}
],
"themeColor": "26292E"
}
]</script>