AFAIK this doesn't change the notes API? If you were doing something with notes, surely you'd use that rather than parsing the HTML in this? (if you are parsing the HTML then you're doing it wrong and shouldn't complain if this changes (IMO)) <br>
<br>
On 21 October 2018 20:44:19 CEST, Tom Hughes <notifications@github.com> wrote:<br>
>Granted this is redundant but you could equally argue that it's always<br>
>redundant to include the recent comment because it's in the full note.<br>
><br>
>As it stands this would for example break any downstream user of the<br>
>feed that chose just to ignore the comment and always show the full<br>
>version of the note so it seems to be to be quite a risky change to<br>
>make?<br>
<br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431694354">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLe2FxMC_g5CjG1SW9Wr0NB2FZRayks5unMN4gaJpZM4XyAW2">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLYMEnZadxujk-R0q-Rwz06zl9P62ks5unMN4gaJpZM4XyAW2.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rory in #2029: AFAIK this doesn't change the notes API? If you were doing something with notes, surely you'd use that rather than parsing the HTML in this? (if you are parsing the HTML then you're doing it wrong and shouldn't complain if this changes (IMO)) \n\nOn 21 October 2018 20:44:19 CEST, Tom Hughes \u003cnotifications@github.com\u003e wrote:\n\u003eGranted this is redundant but you could equally argue that it's always\n\u003eredundant to include the recent comment because it's in the full note.\n\u003e\n\u003eAs it stands this would for example break any downstream user of the\n\u003efeed that chose just to ignore the comment and always show the full\n\u003eversion of the note so it seems to be to be quite a risky change to\n\u003emake?\n\n-- \nSent from my Android device with K-9 Mail. Please excuse my brevity.\n"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431694354"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431694354",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431694354",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] Don't duplicate note comments in RSS feeds for new notes (#2029)",
"sections": [
{
"text": "",
"activityTitle": "**Rory McCann**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@rory",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2029,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 2029\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431694354"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 398984630\n}"
}
],
"themeColor": "26292E"
}
]</script>