<blockquote>
<p>I'm not sure who uses it and what for</p>
</blockquote>
<p>I do! <g-emoji class="g-emoji" alias="slightly_smiling_face" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f642.png">🙂</g-emoji> I have it in my RSS reader so I can monitor the notes in an area.</p>
<blockquote>
<p>so that notes reappear when they have a new comment right?</p>
</blockquote>
<p>Correct.</p>
<blockquote>
<p>But it has this weird dual thing of showing both the latest comment (that caused it to be included) and the whole thread?</p>
</blockquote>
<p>Yes. When there's a "comment" on a note (including the opening of the note), there's an entry in the feed, which includes that comment, and then all the comments in/on that note. So when a note is opened, the first comment is displayed twice.</p>
<blockquote>
<p>you change doesn't really fix that because we still get the duplication the second time round - why is it a problem for a new note and not for subsequent comments?</p>
</blockquote>
<p>My ruby skills are underdeveloped <g-emoji class="g-emoji" alias="wink" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f609.png">😉</g-emoji>, so I didn't try too much. This patch is an improvement, while not making things perfect.</p>
<p>Yes when there's the (e.g.) 5th comment on a note, that comment will appear twice (at the top and as part of the 'whole note'). IMO this isn't so bad. Including the whole note (w/ all comments in chronological order) in each feed entry is good. And including, at the top, the comment that caused this feed is good too. So I think removing the 5th comment from the 'whole note' section is bad, and removing it from the top is bad too.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431756247">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLW9HBKHN-hLjzvsHFpDrPo0GUhQ1ks5unW9UgaJpZM4XyAW2">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLXhYuhbFRhYLyHpBZMgL_mOOMV48ks5unW9UgaJpZM4XyAW2.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rory in #2029: \u003e I'm not sure who uses it and what for\r\n\r\nI do! 🙂 I have it in my RSS reader so I can monitor the notes in an area.\r\n\r\n\u003e so that notes reappear when they have a new comment right?\r\n\r\nCorrect.\r\n\r\n\u003e But it has this weird dual thing of showing both the latest comment (that caused it to be included) and the whole thread?\r\n\r\nYes. When there's a \"comment\" on a note (including the opening of the note), there's an entry in the feed, which includes that comment, and then all the comments in/on that note. So when a note is opened, the first comment is displayed twice.\r\n\r\n\u003e you change doesn't really fix that because we still get the duplication the second time round - why is it a problem for a new note and not for subsequent comments?\r\n\r\nMy ruby skills are underdeveloped 😉, so I didn't try too much. This patch is an improvement, while not making things perfect.\r\n\r\nYes when there's the (e.g.) 5th comment on a note, that comment will appear twice (at the top and as part of the 'whole note'). IMO this isn't so bad. Including the whole note (w/ all comments in chronological order) in each feed entry is good. And including, at the top, the comment that caused this feed is good too. So I think removing the 5th comment from the 'whole note' section is bad, and removing it from the top is bad too. "}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431756247"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431756247",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431756247",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] Don't duplicate note comments in RSS feeds for new notes (#2029)",
"sections": [
{
"text": "",
"activityTitle": "**Rory McCann**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@rory",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2029,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 2029\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431756247"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 398984630\n}"
}
],
"themeColor": "26292E"
}
]</script>