<p>Is there any chance you can have a look at the failing test?</p>
<p>Apparently the <code>User</code> model should be invalid when the <code>display_name</code> is set to <code>nil</code>, but I've just tried it out locally in the rails console and <code>display_name: nil</code> comes back as valid.. (which matches the validations)</p>
<p>There is an existing comment in the test wondering why <code>display_name: nil</code> is invalid, which seems to not be the case anymore!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2044#issuecomment-435697671">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLavsPaGxmwRjrXpK0eBBL4driAMmks5urz5dgaJpZM4YNX4E">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLSdrCqBgjm_wdDamf859IC8SeZqMks5urz5dgaJpZM4YNX4E.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jguthrie100 in #2044: Is there any chance you can have a look at the failing test?\r\n\r\nApparently the `User` model should be invalid when the `display_name` is set to `nil`, but I've just tried it out locally in the rails console and `display_name: nil` comes back as valid.. (which matches the validations)\r\n\r\nThere is an existing comment in the test wondering why `display_name: nil` is invalid, which seems to not be the case anymore!"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2044#issuecomment-435697671"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2044#issuecomment-435697671",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2044#issuecomment-435697671",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] Specifiy invalid chars in username error message (#2044)",
"sections": [
{
"text": "",
"activityTitle": "**Jamie Guthrie**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@jguthrie100",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2044,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 2044\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2044#issuecomment-435697671"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 406158852\n}"
}
],
"themeColor": "26292E"
}
]</script>