<p>I added some extra code in <a class="commit-link" href="https://github.com/openstreetmap/openstreetmap-website/commit/ccdec3ed4c0f7c472f6db7e5eff2dfc1579f3dd1"><tt>ccdec3e</tt></a> to try return nicer errors when the client is a browser... In practice I don't think that there is any path (other than deliberate mucking about) that should get you to those errors because you should only see the links if you are logged in as a moderator.</p>
<p>Much the same goes for the custom <code>deny_access</code> for diary entries, issues and issue comments in that I don't think they can generally happen so we should probably just let them hit the default.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2051#issuecomment-437131328">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLT2KccTZOBX8znqwRG29neX2k5qqks5utIoLgaJpZM4YSXCE">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLYt6zsie1nwzRhAtxfvRXtMQ3gX-ks5utIoLgaJpZM4YSXCE.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes in #2051: I added some extra code in ccdec3ed4c0f7c472f6db7e5eff2dfc1579f3dd1 to try return nicer errors when the client is a browser... In practice I don't think that there is any path (other than deliberate mucking about) that should get you to those errors because you should only see the links if you are logged in as a moderator.\r\n\r\nMuch the same goes for the custom `deny_access` for diary entries, issues and issue comments in that I don't think they can generally happen so we should probably just let them hit the default."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2051#issuecomment-437131328"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2051#issuecomment-437131328",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2051#issuecomment-437131328",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] CanCanCan for user blocks and redactions (#2051)",
"sections": [
{
"text": "",
"activityTitle": "**Tom Hughes**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@tomhughes",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2051,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2051#issuecomment-437131328"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 407466116\n}"
}
],
"themeColor": "26292E"
}
]</script>