<p>My immediate inclination is that the tests should be fixed - if a test is testing the API then it should request the kind of format a real API client would. That said, given these are controller tests, it's all a bit fake anyway.</p>
<p>Setting a default format is not a bad idea - the default format for our API is really XML and that is what we would likely want to send to a client that didn't request anything else anyway.</p>
<p>I think there's a better way than using <code>before_action</code> though, by attaching the default to the routes - we already do that for the notes routes and a few others.</p>
<p>Better separation of API and web site methods would of course also be good but I think that's a larger, and really separate, problem.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/2064#issuecomment-438780677">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLbG11zcJWv0pGF7UahcqBtBev-Z7ks5uvGpHgaJpZM4YeUa6">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLU4iPbKeXGi7OiRxaPdtMrTn5Qv-ks5uvGpHgaJpZM4YeUa6.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes in #2064: My immediate inclination is that the tests should be fixed - if a test is testing the API then it should request the kind of format a real API client would. That said, given these are controller tests, it's all a bit fake anyway.\r\n\r\nSetting a default format is not a bad idea - the default format for our API is really XML and that is what we would likely want to send to a client that didn't request anything else anyway.\r\n\r\nI think there's a better way than using `before_action` though, by attaching the default to the routes - we already do that for the notes routes and a few others.\r\n\r\nBetter separation of API and web site methods would of course also be good but I think that's a larger, and really separate, problem."}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/2064#issuecomment-438780677"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/2064#issuecomment-438780677",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/2064#issuecomment-438780677",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [openstreetmap/openstreetmap-website] Problem with deny_access and request formats during tests (#2064)",
"sections": [
{
"text": "",
"activityTitle": "**Tom Hughes**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@tomhughes",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2064,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2064\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/issues/2064#issuecomment-438780677"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 410601146\n}"
}
],
"themeColor": "26292E"
}
]</script>