<p><b>@tomhughes</b> requested changes on this pull request.</p>

<p>In addition to the above it needs a test as <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=360803" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> explained.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2034#discussion_r235127264">db/migrate/058_name_unnamed_redactions.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,19 @@
+class NameUnnamedRedactions < ActiveRecord::Migration[5.0]
+  def self.up
+    Redaction.find_each do |redaction|
+        if redaction.title.empty?
</pre>
<p>Indentation should be the standard two spaces please.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2034#discussion_r235127597">db/migrate/058_name_unnamed_redactions.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,19 @@
+class NameUnnamedRedactions < ActiveRecord::Migration[5.0]
+  def self.up
+    Redaction.find_each do |redaction|
+        if redaction.title.empty?
+            redaction.title = redaction.id.to_s
+            redaction.save!
+        end
+    end
</pre>
<p>After you fixed any blank titles you need to use <code>change_column</code> to add a "not null" constraint to it.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2034#discussion_r235127792">db/migrate/058_name_unnamed_redactions.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,19 @@
+class NameUnnamedRedactions < ActiveRecord::Migration[5.0]
+  def self.up
+    Redaction.find_each do |redaction|
+        if redaction.title.empty?
+            redaction.title = redaction.id.to_s
+            redaction.save!
+        end
+    end
+  end
+
+  def self.down
+    Redaction.find_each do |redaction|
</pre>
<p>There's no need to change the titles back here, but you do need to remove the constraint with <code>change_column</code> here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2034#pullrequestreview-176922418">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLeKib0uPWijKIdEJak6agUmmT9xrks5uxFAYgaJpZM4X3FF3">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLdNQ7URktTnwxBaSAdwSAKIy5RUDks5uxFAYgaJpZM4X3FF3.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #2034"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2034#pullrequestreview-176922418"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2034#pullrequestreview-176922418",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2034#pullrequestreview-176922418",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@tomhughes requested changes on 2034",
"sections": [
{
"text": "In addition to the above it needs a test as @gravitystorm explained.",
"activityTitle": "**Tom Hughes**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@tomhughes",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2034#pullrequestreview-176922418"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 400314743\n}"
}
],
"themeColor": "26292E"
}
]</script>