<p>This is the feature for multiple phone numbers (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="383614693" data-permission-text="Issue title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2069" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/2069/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/2069">#2069</a>) again. I'm now following the existing code in accepting the / symbol in phone number links. I also adjusted the tests so the comparison is clean.</p>
<p>(Note: I'm submitting this as a new PR so that the commit history is cleaner than my first try (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="384015858" data-permission-text="Issue title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2071" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/2071/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/2071">#2071</a>). github won't let me reopen the same PR since I force-pushed to the same branch.)</p>
<p>The feature is now implemented in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/5ba64efd7c426b99b4bcbad7a9b841daf13eba06/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/5ba64efd7c426b99b4bcbad7a9b841daf13eba06"><tt>5ba64ef</tt></a>, which led to rubocop offenses that I resolved in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/d44ae2efc8247dd2b407d5bbba0f189167781df3/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/d44ae2efc8247dd2b407d5bbba0f189167781df3"><tt>d44ae2e</tt></a> and <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/4826a6e31cc00ab243b84e2c5dfc4b3cd57c1f79/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/4826a6e31cc00ab243b84e2c5dfc4b3cd57c1f79"><tt>4826a6e</tt></a>. Let me know if this is suitable.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/2072'>https://github.com/openstreetmap/openstreetmap-website/pull/2072</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Show tel: links for multiple phone numbers separated by ;</li>
<li>Fix AssignmentInCondition rubocop offenses in browse_helper.rb</li>
<li>Split browse_helper.rb into two modules due to rubocop ModuleLength</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2072/files#diff-0">.rubocop_todo.yml</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2072/files#diff-1">app/helpers/browse_helper.rb</a>
(115)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2072/files#diff-2">app/helpers/format_links_helper.rb</a>
(138)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2072/files#diff-3">test/helpers/browse_helper_test.rb</a>
(216)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/2072/files#diff-4">test/helpers/format_links_helper_test.rb</a>
(263)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/2072.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/2072.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/2072.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/2072.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2072">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLS0iGE71CeqILOfETn9xP3XIjIonks5uzKFmgaJpZM4Y0ZKk">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLR9DZD_QPSKuTVgCQnw2d18u8MT1ks5uzKFmgaJpZM4Y0ZKk.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Show tel: links for multiple phone numbers separated by ; (#2072)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2072"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2072",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2072",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Show tel: links for multiple phone numbers separated by ; (#2072)",
"sections": [
{
"text": "",
"activityTitle": "**krubokrubo**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@krubokrubo",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "5ba64ef",
"value": "Show tel: links for multiple phone numbers separated by ;"
},
{
"name": "d44ae2e",
"value": "Fix AssignmentInCondition rubocop offenses in browse_helper.rb"
},
{
"name": "4826a6e",
"value": "Split browse_helper.rb into two modules due to rubocop ModuleLength"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[.rubocop_todo.yml](https://github.com/openstreetmap/openstreetmap-website/pull/2072/files#diff-0) (1 changes)"
},
{
"name": "Modified",
"value": "[app/helpers/browse_helper.rb](https://github.com/openstreetmap/openstreetmap-website/pull/2072/files#diff-1) (115 changes)"
},
{
"name": "Added",
"value": "[app/helpers/format_links_helper.rb](https://github.com/openstreetmap/openstreetmap-website/pull/2072/files#diff-2) (138 changes)"
},
{
"name": "Modified",
"value": "[test/helpers/browse_helper_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/2072/files#diff-3) (216 changes)"
},
{
"name": "Added",
"value": "[test/helpers/format_links_helper_test.rb](https://github.com/openstreetmap/openstreetmap-website/pull/2072/files#diff-4) (263 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"issueId\": 2072,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"openstreetmap/openstreetmap-website\",\n\"pullRequestId\": 2072\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2072"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2072.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/openstreetmap/openstreetmap-website/pull/2072.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 416387748\n}"
}
],
"themeColor": "26292E"
}
]</script>