<p>I had to partially revert this in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/eb7c4cdedd4f18ceb7362b0f1766f4a8b0dfca62/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/eb7c4cdedd4f18ceb7362b0f1766f4a8b0dfca62"><tt>eb7c4cd</tt></a> because we still need to allow actions which don't require a login.</p>
<p>I'm not sure if my solution there is the best one or not, or if we should separate out the common actions that don't require a login into another class?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2083#issuecomment-446774775">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLeKr8UVYUs4uwOJULEKYsmhZWaj4ks5u4Yi2gaJpZM4ZPpNb">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLVwWG7nNvnVjSz0YauLHVhuvGWctks5u4Yi2gaJpZM4ZPpNb.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes in #2083: I had to partially revert this in eb7c4cdedd4f18ceb7362b0f1766f4a8b0dfca62 because we still need to allow actions which don't require a login.\r\n\r\nI'm not sure if my solution there is the best one or not, or if we should separate out the common actions that don't require a login into another class?"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2083#issuecomment-446774775"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2083#issuecomment-446774775",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2083#issuecomment-446774775",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>