<p>Ah, sorry about that. I think your approach is fine for now, because the tokens are only set up for particular actions (via <code>authorize</code> vs <code>authorize_web</code>).</p>
<p>I want to avoid allowing tokens (and basic auth) to be used for non-api methods by mistake, so technically they shouldn't get all the permissions from Ability.new(nil) since that includes a lot of non-API methods. But we can come back to this later, since (afaict) it doesn't matter yet.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2083#issuecomment-446910290">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLcK4Z0JYr19UCLJWDQ7TdDNJ8qfDks5u4iVlgaJpZM4ZPpNb">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLf3XL1x0BzWdgjO2YxKmyxkAnbdkks5u4iVlgaJpZM4ZPpNb.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #2083: Ah, sorry about that. I think your approach is fine for now, because the tokens are only set up for particular actions (via `authorize` vs `authorize_web`). \r\n\r\nI want to avoid allowing tokens (and basic auth) to be used for non-api methods by mistake, so technically they shouldn't get all the permissions from Ability.new(nil) since that includes a lot of non-API methods. But we can come back to this later, since (afaict) it doesn't matter yet."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2083#issuecomment-446910290"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2083#issuecomment-446910290",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2083#issuecomment-446910290",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>