<blockquote>
<p>Well <a href="https://github.com/openstreetmap/openstreetmap-website/blob/master/test/integration/user_creation_test.rb#L75">https://github.com/openstreetmap/openstreetmap-website/blob/master/test/integration/user_creation_test.rb#L75</a> tests the signup flow including accepting the terms?</p>
<p>If you actually want to check what happens to the button on the client then you will need a system test though obviously you want to check that the backend works right as well as you don't want to trust client side javascript ;-)</p>
</blockquote>
<p>I'll punt on the client side javascript :-) (assuming that we don't actually have any kind of test harness that directly simulates user interaction), But since the requirement that the checkbox is checked is the only functional aspect that could be tested separately I'm a bit at a loss to find any sensible additional testable condition, so IMHO I would let things stand as they are now (when and if we add code to force ToU acceptance for existing users that can be revisited).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2028#issuecomment-450882896">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLVDlbl0u1BnziytOj9uW0lXYEjlgks5u_MeYgaJpZM4Xx7yL">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLfQVbW9kZXNIwujFaoHtvZPCNxmFks5u_MeYgaJpZM4Xx7yL.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@simonpoole in #2028: \u003e \r\n\u003e \r\n\u003e Well https://github.com/openstreetmap/openstreetmap-website/blob/master/test/integration/user_creation_test.rb#L75 tests the signup flow including accepting the terms?\r\n\u003e \r\n\u003e If you actually want to check what happens to the button on the client then you will need a system test though obviously you want to check that the backend works right as well as you don't want to trust client side javascript ;-)\r\n\r\nI'll punt on the client side javascript :-) (assuming that we don't actually have any kind of test harness that directly simulates user interaction), But since the requirement that the checkbox is checked is the only functional aspect that could be tested separately I'm a bit at a loss to find any sensible additional testable condition, so IMHO I would let things stand as they are now (when and if we add code to force ToU acceptance for existing users that can be revisited)."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2028#issuecomment-450882896"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2028#issuecomment-450882896",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2028#issuecomment-450882896",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>