<p>OK, looks good to me!</p>
<blockquote>
<p>Note that this doesn't fix all the issues in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="397251466" data-permission-text="Issue title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2103" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/2103/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/2103">#2103</a> as bullet lists nested in numbered lists still don't seem to work as the reporter there is expecting.</p>
</blockquote>
<p>That's a problem with our stylesheets - the html outputted by kramdown seems correct as it's outputting <code><ul></code> tags for the bullet lists. But <a href="https://github.com/openstreetmap/openstreetmap-website/blob/fbbabeff1e3bc473720e6eaece83825a9c349ba8/app/assets/stylesheets/common.scss#L2349-L2351">in our stylesheets</a> we have:</p>
<pre><code>ol li {
list-style: decimal;
}
</code></pre>
<p>... and as far as I can tell, that means that any <code><ul></code> instead of a <code><ol><li></code> will inherit the decimal list style. Perhaps we could fix that as a followup.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2111#issuecomment-454714092">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLfo2jupUFU4rxlYumhTfQ55coYREks5vDvMmgaJpZM4Z4BBa">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLfYtwq0ZByNrmMvKm8-78WKK0uvhks5vDvMmgaJpZM4Z4BBa.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #2111: OK, looks good to me!\r\n\r\n\u003e Note that this doesn't fix all the issues in #2103 as bullet lists nested in numbered lists still don't seem to work as the reporter there is expecting.\r\n\r\nThat's a problem with our stylesheets - the html outputted by kramdown seems correct as it's outputting `\u003cul\u003e` tags for the bullet lists. But [in our stylesheets](https://github.com/openstreetmap/openstreetmap-website/blob/fbbabeff1e3bc473720e6eaece83825a9c349ba8/app/assets/stylesheets/common.scss#L2349-L2351) we have:\r\n\r\n```\r\nol li {\r\n list-style: decimal;\r\n}\r\n```\r\n... and as far as I can tell, that means that any `\u003cul\u003e` instead of a `\u003col\u003e\u003cli\u003e` will inherit the decimal list style. Perhaps we could fix that as a followup.\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2111#issuecomment-454714092"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2111#issuecomment-454714092",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2111#issuecomment-454714092",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>