<blockquote>
<p>Bulk INSERT is quite crucial from a performance pov, otherwise this thing is barely usable</p>
</blockquote>
<p>I worked on it last week too, after I made the pull request, and it was <a href="https://github.com/gravitystorm/openstreetmap-website/commit/74e1b98ea2701b722ebbb124e03f272848c51676">pretty straightforward</a>. I noticed that the way the import method currently works involved multiple passes at the XML parsing, so I want to look at that too. But in general, I'm a fan of incremental pull requests, to make the reviews more straightforward.</p>
<p>I'll work on this further next week.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2120#issuecomment-458251497">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLW2ERpUaunMow7YoXS6NOfQmHJUjks5vH0SHgaJpZM4aDUsB">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLc-uGu7kjUCAP298Fx4l0yfiMFN2ks5vH0SHgaJpZM4aDUsB.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #2120: \u003e Bulk INSERT is quite crucial from a performance pov, otherwise this thing is barely usable\r\n\r\nI worked on it last week too, after I made the pull request, and it was [pretty straightforward](https://github.com/gravitystorm/openstreetmap-website/commit/74e1b98ea2701b722ebbb124e03f272848c51676). I noticed that the way the import method currently works involved multiple passes at the XML parsing, so I want to look at that too. But in general, I'm a fan of incremental pull requests, to make the reviews more straightforward.\r\n\r\nI'll work on this further next week."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2120#issuecomment-458251497"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2120#issuecomment-458251497",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2120#issuecomment-458251497",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>