<p><b>@tomhughes</b> requested changes on this pull request.</p>

<p>So looking at the UI this present I have to say I find it very confusing... This is what the terms page now looks like:</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/147741/52004965-6d71b500-24c0-11e9-9419-0f06c85b363b.png"><img src="https://user-images.githubusercontent.com/147741/52004965-6d71b500-24c0-11e9-9419-0f06c85b363b.png" alt="screenshot_2019-01-30 contributor terms openstreetmap" style="max-width:100%;"></a></p>
<p>So I have a checkbox to say I accept the ToU and then underneath that we have Agree/Decline buttons, which actually refer to the contributor terms at the top but that's like totally not obvious to me at least.</p>
<p>I think fundamentally it's just odd to have two agree/disagree questions which are answered in different ways - one by checking a box and one by choosing which submit button to press?</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2028#discussion_r252389265">app/controllers/users_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -41,7 +41,7 @@ def terms
   def save
     @title = t "users.new.title"
 
-    if params[:decline]
+    if params[:decline] || !params[:read_tou] || params[:read_tou] == "0"
</pre>
<p>You don't actually need both tests here as "truthiness" means that <code>"0"</code> is false and hence the first test will be true...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2028#pullrequestreview-198245960">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLaPceZGyU61uTIDyZy5dcBqwEuLNks5vIerqgaJpZM4Xx7yL">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLduB3YaWk7_M-CZkjIg0c2BH6c11ks5vIerqgaJpZM4Xx7yL.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #2028"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2028#pullrequestreview-198245960"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2028#pullrequestreview-198245960",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2028#pullrequestreview-198245960",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>