<p>One consideration here is around memory usage. The gpx.points yields tracepoints one at a time, which keeps memory usage low. But to insert them in bulk, we obviously need many tracepoints available at the same time, so we collect them up before bulk inserting.</p>
<p>Thoughts welcome! Do you think this will work as-is, or do we need to be more defensive about building the tracepoint array?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2131#issuecomment-460969451">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLfuU29KrLdVLhiHoE4E3h_Ete68xks5vKqsIgaJpZM4ak4vv">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLStevkdWUS7asAWRN9fJEJEdw2Koks5vKqsIgaJpZM4ak4vv.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #2131: One consideration here is around memory usage. The gpx.points yields tracepoints one at a time, which keeps memory usage low. But to insert them in bulk, we obviously need many tracepoints available at the same time, so we collect them up before bulk inserting.\r\n\r\nThoughts welcome! Do you think this will work as-is, or do we need to be more defensive about building the tracepoint array?"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2131#issuecomment-460969451"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2131#issuecomment-460969451",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2131#issuecomment-460969451",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>