<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1914#discussion_r259574302">app/helpers/user_membership_helper.rb</a>:</p>
<pre style='color:#555'>> +module UserMembershipHelper
+  def membership_icons(user)
+    UserMembership::ALL_MEMBERSHIPS.reduce("".html_safe) do |acc, elem|
+      acc + " " + membership_icon(user, elem)
+    end
+  end
+
+  def membership_icon(user, membership)
+    if user.show_membership?(membership)
+      image = "membership/#{membership}"
+      alt = t("user.view.membership.#{membership}")
+      title = t("user.view.membership.#{membership}")
+      id = "badge-membership-#{membership}"
+    end
+
+    if image
</pre>
<p>This will always evaluate to true, if the <code>user.show_membership?</code> evaluated to true. So I think it would be better to combine the two if statements</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1914#pullrequestreview-207104809">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLbyXRDgxO1GuJk9U0P1EDt4UJPP8ks5vQRZJgaJpZM4U1H6q">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLd3iOSVma0SvB0iqLN07I0eUWZReks5vQRZJgaJpZM4U1H6q.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm commented on #1914"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1914#pullrequestreview-207104809"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/1914#pullrequestreview-207104809",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/1914#pullrequestreview-207104809",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>