<p>See the problem with your design is that it requires storing potentially enormous diffresult text in the database...</p>
<p>Oh, and that exclusive lock is just going to timeout every time if a previous upload is still running...</p>
<p>Also if we're checking a hash of the request why do we even need the idempotency key? I thought the idea was that the client would use a different key when the request changed so that just comparing the key was enough?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-480602431">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLcYN2g_LLRtK1KN7OYBC1-Y_1GM5ks5vehPKgaJpZM4cgFOf">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLW2iMLvv8VLuZtj0OzyyA4OE58Myks5vehPKgaJpZM4cgFOf.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes in #2201: See the problem with your design is that it requires storing potentially enormous diffresult text in the database... \r\n\r\nOh, and that exclusive lock is just going to timeout every time if a previous upload is still running...\r\n\r\nAlso if we're checking a hash of the request why do we even need the idempotency key? I thought the idea was that the client would use a different key when the request changed so that just comparing the key was enough?"}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-480602431"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-480602431",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-480602431",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>