<p>Sadly while <code>eslint-rails-ee</code> is better than the original <code>eslint-rails</code> it turns out that the version of <code>eslint</code> it is bundling is still ancient and I'd really like to use something newer.</p>
<p>So this PR tries a new approach, installing eslint directly with yarn and then using a simple rake task to invoke it.</p>
<p>I chose to use yarn rather than npm simply because that is the preferred tool for managing javascript dependencies in rails although it does make it a bit more of a pain for people to setup.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/2209'>https://github.com/openstreetmap/openstreetmap-website/pull/2209</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Replace eslint-rails-ee with direct calls to eslint</li>
  <li>Fix new eslint warnings</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2209/files#diff-0">.gitignore</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2209/files#diff-1">.travis.yml</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2209/files#diff-2">Gemfile</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2209/files#diff-3">Gemfile.lock</a>
    (13)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2209/files#diff-4">app/assets/javascripts/leaflet.zoom.js</a>
    (102)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2209/files#diff-5">app/assets/javascripts/router.js</a>
    (4)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2209/files#diff-6">lib/tasks/eslint.rake</a>
    (27)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2209/files#diff-7">package.json</a>
    (9)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2209/files#diff-8">yarn.lock</a>
    (769)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/2209.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/2209.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/2209.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/2209.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2209">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLUkNCLl1LVZslHlepF8eMQlwaXHCks5vg3kdgaJpZM4cuyKB">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLYj2nI0-5iaXy_VDQdQjNdDzAxQPks5vg3kdgaJpZM4cuyKB.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Eslint (#2209)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2209"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2209",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2209",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>