<p>This all lost fine for the most part but it does create a slightly confusing naming situation.</p>
<p>We wind up with a <code>trace</code> view that actually takes an argument named <code>@traces</code> and renders multiple traces so that it can also support a separate action on the user controller.</p>
<p>One option would be just to rename it to <code>traces</code> so that things are consistent, but that means we have a view that doesn't directly relate to any action. The only other approach I can see is to have separate top level views though they could still share the common partial where most of the work is done.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2207#issuecomment-482999547">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLRRUdYBwGesI7PXTOZxzl3nbccsZks5vg0mZgaJpZM4ctuTl">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLVX6V7K9gnoocN1bO4m1f2ZodjqFks5vg0mZgaJpZM4ctuTl.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes in #2207: This all lost fine for the most part but it does create a slightly confusing naming situation.\r\n\r\nWe wind up with a `trace` view that actually takes an argument named `@traces` and renders multiple traces so that it can also support a separate action on the user controller.\r\n\r\nOne option would be just to rename it to `traces` so that things are consistent, but that means we have a view that doesn't directly relate to any action. The only other approach I can see is to have separate top level views though they could still share the common partial where most of the work is done."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/2207#issuecomment-482999547"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2207#issuecomment-482999547",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2207#issuecomment-482999547",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>