<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5842757" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mmd-osm">@mmd-osm</a> given my understanding of the issue, it would only be exercised if we (in the case of Vespucci manually) retried after a failed attempt, and the original connection hadn't already been evicted from the cache.</p>
<p>As we are then already retrying in a situation in which we shouldn't be doing so blindly I kind to fail to see  (independent of the app in question) the net result being different than if you retried without the mechanism in OkHttp. Which further implies that it is practically impossible to determine if that has ever happened. I can see the behaviour being problematic if after the failure you try to upload something else, but that is not going to be the case in our use scenario.</p>
<p>To recap: I think we should do something about the issue, my only problem with your approach is that you are rewarding doing the wrong thing and not supplying a solution for devs that don't want to go that route, forcing us to emulate JOSMs broken behaviour.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-485177158">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLL7LA7MHVCEPJDU5ATPROEIVANCNFSM4HEAKOPQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAK2OLKCGTZGEJEJAKM46ILPROEIVANCNFSM4HEAKOPQ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@simonpoole in #2201: @mmd-osm given my understanding of the issue, it would only be exercised if we (in the case of Vespucci manually) retried after a failed attempt, and the original connection hadn't already been evicted from the cache. \r\n\r\nAs we are then already retrying in a situation in which we shouldn't be doing so blindly I kind to fail to see  (independent of the app in question) the net result being different than if you retried without the mechanism in OkHttp. Which further implies that it is practically impossible to determine if that has ever happened. I can see the behaviour being problematic if after the failure you try to upload something else, but that is not going to be the case in our use scenario.\r\n\r\nTo recap: I think we should do something about the issue, my only problem with your approach is that you are rewarding doing the wrong thing and not supplying a solution for devs that don't want to go that route, forcing us to emulate JOSMs broken behaviour."}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-485177158"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-485177158",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-485177158",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>