<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1011860" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/simonpoole">@simonpoole</a> : I was sort of expecting your feedback on my proposal to include an auto close (-> <code>close_changeset=true</code>) attribute in the osmChange message (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="430010870" data-permission-text="Issue title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2201" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/2201/hovercard?comment_id=485230581&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-485230581">#2201 (comment)</a>).</p>
<p>Several people in this issue seem to suggest that they want atomic changesets, which this attribute would enable. If the upload fails or times out, it would be safe to re-upload: either the osmChange mesasge gets processed, or rejected in case the changeset is already closed.</p>
<p>I don't want to introduce <em>one upload per changeset</em> as a default behavior, as it would be an incompatible, breaking change. Adding that attribute is the next best thing to do. By the way, a additional URL parameter "<code>?close_changeset=true"</code> could serve a similar purpose, if there are concerns about extending the XML structure.</p>
<p>Should we go for this as one option, and continue with the diffResult topic?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-488663239">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMNRF4O6UQVCYQIDFLPTLQYXANCNFSM4HEAKOPQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAK2OLIEYZR3H7EANJJE54LPTLQYXA5CNFSM4HEAKOP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODUQGRRY.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mmd-osm in #2201: @simonpoole : I was sort of expecting your feedback on my proposal to include an auto close (-\u003e `close_changeset=true`) attribute in the osmChange message (https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-485230581).\r\n\r\nSeveral people in this issue seem to suggest that they want atomic changesets, which this attribute would enable. If the upload fails or times out, it would be safe to re-upload: either the osmChange mesasge gets processed, or rejected in case the changeset is already closed.\r\n\r\nI don't want to introduce _one upload per changeset_ as a default behavior, as it would be an incompatible, breaking change. Adding that attribute is the next best thing to do. By the way, a additional URL parameter \"`?close_changeset=true\"` could serve a similar purpose, if there are concerns about extending the XML structure.\r\n\r\nShould we go for this as one option, and continue with the diffResult topic?\r\n\r\n\r\n\r\n"}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-488663239"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-488663239",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/2201#issuecomment-488663239",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>