<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2248#discussion_r290826562">test/controllers/diary_entries_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -85,6 +85,10 @@ def test_routes
       { :path => "/user/username/diary/1/hide", :method => :post },
       { :controller => "diary_entries", :action => "hide", :display_name => "username", :id => "1" }
     )
+    assert_routing(
+      { :path => "/user/username/diary/1/unhide", :method => :post },
+      { :controller => "diary_entries", :action => "unhide", :display_name => "username", :id => "1" }
+    )
</pre>
<p>Shouldn't there be a routing test for <code>unhidecomment</code> as well?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2248#discussion_r290826976">test/system/diary_entry_test.rb</a>:</p>
<pre style='color:#555'>> +    sign_in_as(create(:administrator_user))
+    visit diary_entries_path
+
+    assert_not page.has_content? @deleted_entry.title
+  end
+
+  test "deleted diary comments should be hidden for regular users" do
+    @deleted_comment = create(:diary_comment, :diary_entry => @diary_entry, :visible => false)
+
+    sign_in_as(create(:user))
+    visit diary_entry_path(@diary_entry.user, @diary_entry)
+
+    assert_not page.has_content? @deleted_comment.body
+  end
+
+  test "deleted diary comments should be show to administrators" do
</pre>
<p>I assume <code>show</code> should be <code>shown</code> here...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2248?email_source=notifications&email_token=AAK2OLPRLD7JPHKEDM6ZPOTPY7SQZA5CNFSM4HTYQBX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2VXV6Q#pullrequestreview-246119162">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIQJZCVDELUKKW7WL3PY7SQZANCNFSM4HTYQBXQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAK2OLOOTICLJOEBJIVEPELPY7SQZA5CNFSM4HTYQBX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2VXV6Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2248?email_source=notifications\u0026email_token=AAK2OLPRLD7JPHKEDM6ZPOTPY7SQZA5CNFSM4HTYQBX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2VXV6Q#pullrequestreview-246119162",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2248?email_source=notifications\u0026email_token=AAK2OLPRLD7JPHKEDM6ZPOTPY7SQZA5CNFSM4HTYQBX2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2VXV6Q#pullrequestreview-246119162",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>