<p><b>@fazlerabbi37</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2272#discussion_r295693854">docker/Dockerfile</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,25 @@
+FROM ruby:2.5-slim
+
+#install packages
+#fixes dpkg man page softlink error while installing postgresql-client [source: https://github.com/debuerreotype/debuerreotype/issues/10#issuecomment-438342078]
+RUN mkdir -p /usr/share/man/man1 && mkdir -p /usr/share/man/man7
+RUN apt-get update && apt-get install curl -y
+RUN curl -sL https://deb.nodesource.com/setup_10.x -o nodesource_setup.sh && bash nodesource_setup.sh && rm nodesource_setup.sh
+RUN apt-get install -y --no-install-recommends ruby-dev libarchive-dev libmagickwand-dev libxml2-dev libxslt1-dev build-essential libpq-dev libsasl2-dev imagemagick libffi-dev locales postgresql-client-9.6 nodejs && apt-get clean && rm -rf /var/lib/apt/lists/*
</pre>
<blockquote>
<p>I'm also not a Docker expert, but it might be worth considering starting from a different base image, like Ubuntu 18.04, rather than starting from a ruby base image.</p>
</blockquote>
<p>Neither am I. As far as I understand the purpose of using a ruby image it to remove the legwork required to install ruby on an Ubuntu base image. Maybe someone with better docker understanding can explain it better? ping <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1190866" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/pnorman">@pnorman</a></p>
<p>I am building on top of the previous PR (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="177315137" data-permission-text="Issue title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/1290" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/1290/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/1290">#1290</a>) and at first I wanted to see if I can build the <code>web</code> and <code>db</code> images using docker with the new code because the code base and the installation procedure has changed since that PR. If we all agree on the pros, we can change the base image to Ubuntu 18.04.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2272?email_source=notifications&email_token=AAK2OLKICNTVZVLD4A5CZWDP3M45RA5CNFSM4HZNXSCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4DY3JI#discussion_r295693854">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNPD2WT7D3CLF54M4LP3M45RANCNFSM4HZNXSCA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAK2OLM76UP7W2GLFYAVYMTP3M45RA5CNFSM4HZNXSCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4DY3JI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2272?email_source=notifications\u0026email_token=AAK2OLKICNTVZVLD4A5CZWDP3M45RA5CNFSM4HZNXSCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4DY3JI#discussion_r295693854",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2272?email_source=notifications\u0026email_token=AAK2OLKICNTVZVLD4A5CZWDP3M45RA5CNFSM4HZNXSCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4DY3JI#discussion_r295693854",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>