<p><b>@tomhughes</b> commented on this pull request.</p>

<p>I can't see any obvious issues... I mean a lot of the controller code makes me want to gag and can probably be rationalised but that's not anything you've done, it's just how how the code has always been ;-)</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2223#discussion_r300065590">app/views/api/map/index.xml.builder</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,8 @@
+xml.instruct!
+
+xml.osm(OSM::API.new.xml_root_attributes) do |osm|
+  osm << (render(:partial => "bounds", :object => @bounds) || "")
+  osm << (render(@nodes) || "")
+  osm << (render(@ways) || "")
+  osm << (render(@relations) || "")
</pre>
<p>Why do we need all the <code>|| ""</code> stuff here? What does adding a string to the XML even do?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2223?email_source=notifications&email_token=AAK2OLNHSJHBZE3A46SEBI3P5TMC3A5CNFSM4HLMFYO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5NQNFY#pullrequestreview-257623703">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNH6HXBVB2NGRHQ6L3P5TMC3ANCNFSM4HLMFYOQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAK2OLJZXRQUV4KHY646XA3P5TMC3A5CNFSM4HLMFYO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5NQNFY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2223?email_source=notifications\u0026email_token=AAK2OLNHSJHBZE3A46SEBI3P5TMC3A5CNFSM4HLMFYO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5NQNFY#pullrequestreview-257623703",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2223?email_source=notifications\u0026email_token=AAK2OLNHSJHBZE3A46SEBI3P5TMC3A5CNFSM4HLMFYO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB5NQNFY#pullrequestreview-257623703",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>