<blockquote>
<p>Frankly I'm astonished that those minimal models even work - some of our migrations do pretty extreme things and I'm surprised none of them are relying on the details of the models.</p>
<p>I rather suspect that maybe they only work with an empty database, and that some of the ones that try and mutate existing data might fail if there was any data to change?</p>
</blockquote>
<p>Oh almost certainly. But to be honest I'm not going to spend any time on that. If the migrations now work for an empty database, and are more robust to future changes, so much the better.</p>
<p>From a broader perspective, we should really ditch our old migrations. I'd be happy replacing everything before e.g. 2017 with one migration called "2017010101_current_structure" since they are full of dodgy stuff regarding segments and c extensions and whatnot that literally nobody needs to use in 2019. If anyone is truly interested in how they worked, then there's a git history. Otherwise we need to keep maintaining them for no gain.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2320?email_source=notifications&email_token=AAK2OLIIPFERDTMTY4YXCK3P732JBA5CNFSM4IEO2V72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DZWAI#issuecomment-512203521">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJQQFTLCRISPDQF4L3P732JBANCNFSM4IEO2V7Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAK2OLKF35YARKCCPEDZATTP732JBA5CNFSM4IEO2V72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DZWAI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2320?email_source=notifications\u0026email_token=AAK2OLIIPFERDTMTY4YXCK3P732JBA5CNFSM4IEO2V72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DZWAI#issuecomment-512203521",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2320?email_source=notifications\u0026email_token=AAK2OLIIPFERDTMTY4YXCK3P732JBA5CNFSM4IEO2V72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DZWAI#issuecomment-512203521",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>