<p>With <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/40ac2aa5280f46c0c8cf3676596334269ec2f696/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/40ac2aa5280f46c0c8cf3676596334269ec2f696"><tt>40ac2aa</tt></a> I get a test failure, since <code>Settings.server_url</code> (used in the code) != <code>test.host</code> (expected by the tests).</p>
<p>With the parent of that commit, it works fine. I think the problem described in the comments in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="463481130" data-permission-text="Issue title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2296" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/2296/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/2296">#2296</a> was fully fixed by the change from <code>url_for</code> to <code>polymorphic_url</code> in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/b911b45961165d64fba577d4cb87740d89ec6784/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/b911b45961165d64fba577d4cb87740d89ec6784"><tt>b911b45</tt></a>. I found a ticket (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="324963052" data-permission-text="Issue title is private" data-url="https://github.com/rails/rails/issues/32948" data-hovercard-type="issue" data-hovercard-url="/rails/rails/issues/32948/hovercard?comment_id=390817882&comment_type=issue_comment" href="https://github.com/rails/rails/issues/32948#issuecomment-390817882">rails/rails#32948 (comment)</a>) that describes that <code>url_for</code> is expected to give relative urls (which is a documented quirk) whereas <code>polymophic_url</code> should give fully-qualified urls.</p>
<p>Since we us fully-qualified urls all over the place, without needing <code>Settings.url</code> each time, I think it will be safe to remove.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/2319?email_source=notifications&email_token=AAK2OLKGNDXC6MFLINP7W43P73QRTA5CNFSM4IEOKFXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7VU4HA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNJWY2L3HTI7VLGSHDP73QRTANCNFSM4IEOKFXA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAK2OLJCZBAZNXNB7FT3Z6LP73QRTA5CNFSM4IEOKFXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7VU4HA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/2319?email_source=notifications\u0026email_token=AAK2OLKGNDXC6MFLINP7W43P73QRTA5CNFSM4IEOKFXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7VU4HA",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/2319?email_source=notifications\u0026email_token=AAK2OLKGNDXC6MFLINP7W43P73QRTA5CNFSM4IEOKFXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7VU4HA",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>