<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319465393">config/routes.rb</a>:</p>
<pre style='color:#555'>> @@ -1,24 +1,58 @@
 OpenStreetMap::Application.routes.draw do
+  # Our api versions are decimals, but controllers cannot start with a number
+  # or contain punctuation
+  def v_string(version)
+    "v#{version.delete('.')}"
</pre>
<p>As discussed in the comments, semver would only use major version numbers here. So e.g. <code>v7</code> or <code>v124</code>. But it's a great point to raise, thank you.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2353?email_source=notifications&email_token=AAK2OLKBMS657Q4WQQ7LQPTQHD5V7A5CNFSM4IOIASA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDHIINY#discussion_r319465393">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKYDJ26PPLMQWD5QNLQHD5V7ANCNFSM4IOIASAQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAK2OLJZGGPEVHV44Q3GH7DQHD5V7A5CNFSM4IOIASA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDHIINY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2353?email_source=notifications\u0026email_token=AAK2OLKBMS657Q4WQQ7LQPTQHD5V7A5CNFSM4IOIASA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDHIINY#discussion_r319465393",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2353?email_source=notifications\u0026email_token=AAK2OLKBMS657Q4WQQ7LQPTQHD5V7A5CNFSM4IOIASA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDHIINY#discussion_r319465393",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>