<p>So, trying (desperately) to drag the conversation back to the contents of this PR - does anyone have any comments on handling the indentation of the tests? I really dislike PRs that combine widespread indentation with additional changes to the code, since I find it very hard to spot where the real changes are and which lines are just indented with no other change.</p>
<p>I've been considering whether I should split out the indentation into a separate PR, with a dummy <code>indent</code> method like</p>
<div class="highlight highlight-source-ruby"><pre><span class="pl-k">def</span> <span class="pl-en">indent</span>
  <span class="pl-k">yield</span>
<span class="pl-k">end</span></pre></div>
<p>and then make a PR with the methods indented but with no other changes</p>
<div class="highlight highlight-source-diff"><pre>  def test_something
<span class="pl-md"><span class="pl-md">-</span>   code</span>
<span class="pl-md"><span class="pl-md">-</span>   code</span>
<span class="pl-md"><span class="pl-md">-</span>   post :foo</span>
<span class="pl-md"><span class="pl-md">-</span>   code</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>   indent</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>    code</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>    code</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>    post :foo</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>    code</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>   end</span>
  end</pre></div>
<p>and then in the second PR it will be more obvious which of the lines have real changes.</p>
<div class="highlight highlight-source-diff"><pre>  def test_other_thing
<span class="pl-md"><span class="pl-md">-</span>   indent</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>   all_api_versions.each do |version|</span>
      code
      code
<span class="pl-md"><span class="pl-md">-</span>     post :foo</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>     post :foo, params => { etc }</span>
      code
    end
end</pre></div>
<p>Or am I worrying about this too much, and the PR is fine the way it is now?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2353?email_source=notifications&email_token=AAK2OLMWYNYF2EJ7JBGH6BDQH6RG5A5CNFSM4IOIASA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53LRRY#issuecomment-527874247">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKKCXD6WXKKVBTXRH3QH6RG5ANCNFSM4IOIASAQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAK2OLN44BX2EEH75HAB273QH6RG5A5CNFSM4IOIASA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53LRRY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2353?email_source=notifications\u0026email_token=AAK2OLMWYNYF2EJ7JBGH6BDQH6RG5A5CNFSM4IOIASA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53LRRY#issuecomment-527874247",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2353?email_source=notifications\u0026email_token=AAK2OLMWYNYF2EJ7JBGH6BDQH6RG5A5CNFSM4IOIASA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53LRRY#issuecomment-527874247",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>