<p><b>@gravitystorm</b> commented on this pull request.</p>

<p>The migration appears to be unnecessary for our situation, since we started with a version of ActiveStorage that includes the foreign key. But I guess the app:upgrade auto-generated that anyway, and no harm either way.</p>
<p>Everything else looks fine to me. There's a deprecation warning from jsonify but that's not a blocker and can be dealt with separately.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2423#discussion_r345649568">config/environments/test.rb</a>:</p>
<pre style='color:#555'>>    config.middleware.use I18n::JS::Middleware
 
-  # Raises error for missing translations
-  config.action_view.raise_on_missing_translations = true
+  # Raises error for missing translations.
+  # config.action_view.raise_on_missing_translations = true
</pre>
<p>Is this a deliberate change? I think it's quite useful for the tests to fail if a translation is used in a view but there's no entry in config/locales/en.yml</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2423?email_source=notifications&email_token=AAK2OLNDZAOMZVBQPPJO4I3QTPIVTA5CNFSM4JJIFHL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLLVKZI#pullrequestreview-316101989">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJ63SFSO3MXO247NY3QTPIVTANCNFSM4JJIFHLQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLMOMURBFG5A25BC3L3QTPIVTA5CNFSM4JJIFHL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLLVKZI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2423?email_source=notifications\u0026email_token=AAK2OLNDZAOMZVBQPPJO4I3QTPIVTA5CNFSM4JJIFHL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLLVKZI#pullrequestreview-316101989",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2423?email_source=notifications\u0026email_token=AAK2OLNDZAOMZVBQPPJO4I3QTPIVTA5CNFSM4JJIFHL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLLVKZI#pullrequestreview-316101989",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>