<blockquote>
<p>I wonder if the mocking is needed if we're creating unique temp dirs?</p>
</blockquote>
<p>The main thing is that we create symlinks for the images (and traces), and when we run the importer then we overwrite the fixtures. So I was considering just making the factories copy the fixtures rather than making symlinks, which might allow us to ditch all the Fakefs stuff entirely at the cost of lots of copying files around during the tests.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2448?email_source=notifications&email_token=AAK2OLKM2DA6C333W26ZR6LQW6MVVA5CNFSM4JSHIW5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4ZLJY#issuecomment-561616295">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPO63D7NP75OQFJCSDQW6MVVANCNFSM4JSHIW5A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLLDVUWD4ZXONBTFEDLQW6MVVA5CNFSM4JSHIW5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4ZLJY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2448?email_source=notifications\u0026email_token=AAK2OLKM2DA6C333W26ZR6LQW6MVVA5CNFSM4JSHIW5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4ZLJY#issuecomment-561616295",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2448?email_source=notifications\u0026email_token=AAK2OLKM2DA6C333W26ZR6LQW6MVVA5CNFSM4JSHIW5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4ZLJY#issuecomment-561616295",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>