<p><b>@gravitystorm</b> requested changes on this pull request.</p>
<p>Thanks <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/hikemaniac/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/hikemaniac">@hikemaniac</a>! I'm happy with these changes, because:</p>
<ul>
<li>The <code>resize: vertical</code> is the default for bootstrap resets, so if they think it's reasonable that's fine with me.</li>
<li>The border-radius also matches what bootstrap do to text-areas.</li>
<li>I don't have strong opinions on the min-height aspect of this PR so I'm happy to approve it.</li>
</ul>
<p>I should note that the border-radius will also be applied to much more than just text-areas, which isn't clear from your description. For example, you can see it on the input fields on the sign in form. However, I think it looks fine there too so I'm happy to do this, after the other requested changes are resolved.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2464#discussion_r359432551">app/assets/stylesheets/common.scss</a>:</p>
<pre style='color:#555'>> @@ -2092,6 +2092,7 @@ textarea {
color: #222;
background-color: #fff;
border: 1px solid $grey;
+ border-radius: 3px;
</pre>
<p>This should use the <code>$border-radius</code> variable</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2464#discussion_r359433202">app/assets/stylesheets/common.scss</a>:</p>
<pre style='color:#555'>> @@ -2104,6 +2105,11 @@ textarea {
textarea {
padding: 5px;
width: 100%;
+ min-height: 50px;
+}
+
+textarea.comment {
+ resize: vertical;
</pre>
<p>I'd prefer for this to apply to all <code>textarea</code> since other places also go haywire when they are resized horizontally. Simply moving this line to the <code>textarea</code> section immediately above will be enough.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/2464?email_source=notifications&email_token=AAK2OLPDAMLGFSOL6TZCEMDQZJD2NA5CNFSM4J3NWF3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPU35PY#pullrequestreview-334085823">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLIQKZAOSRIOZZBVXLQZJD2NANCNFSM4J3NWF3A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAK2OLMRENXI25AFWGRQGRLQZJD2NA5CNFSM4J3NWF3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPU35PY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/2464?email_source=notifications\u0026email_token=AAK2OLPDAMLGFSOL6TZCEMDQZJD2NA5CNFSM4J3NWF3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPU35PY#pullrequestreview-334085823",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/2464?email_source=notifications\u0026email_token=AAK2OLPDAMLGFSOL6TZCEMDQZJD2NA5CNFSM4J3NWF3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPU35PY#pullrequestreview-334085823",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>